From: "Hervé Poussineau" <hpoussin@reactos.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] isapc: give system address space when pci is disabled
Date: Mon, 19 Sep 2011 20:49:27 +0200 [thread overview]
Message-ID: <4E778EB7.5010706@reactos.org> (raw)
In-Reply-To: <4E76F5F2.7000204@siemens.com>
Jan Kiszka a écrit :
> On 2011-09-18 18:04, Hervé Poussineau wrote:
>> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
>> ---
>> hw/pc_piix.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/hw/pc_piix.c b/hw/pc_piix.c
>> index da6fa55..c0b8a3a 100644
>> --- a/hw/pc_piix.c
>> +++ b/hw/pc_piix.c
>> @@ -121,7 +121,7 @@ static void pc_init1(MemoryRegion *system_memory,
>> pc_memory_init(system_memory,
>> kernel_filename, kernel_cmdline, initrd_filename,
>> below_4g_mem_size, above_4g_mem_size,
>> - pci_memory, &ram_memory);
>> + pci_enabled ? pci_memory : system_memory, &ram_memory);
>> }
>>
>> if (!xen_enabled()) {
>
> Makes sense. I guess we should rename 'pci_memory' inside pc_memory_init
> to reflect this - 'rom_memory'?
>
> But -M isapc still only gives me a black screen. Are there further fixes
> required?
>
Yes, you also need to rollback pc-bios/bios.bin to previous version (ie
8b06c62ae48b67b320f7420dcd4854c5559e1532)
Hervé
next prev parent reply other threads:[~2011-09-19 18:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-18 16:04 [Qemu-devel] [PATCH] isapc: give system address space when pci is disabled Hervé Poussineau
2011-09-19 7:57 ` Jan Kiszka
2011-09-19 18:49 ` Hervé Poussineau [this message]
2011-09-20 8:27 ` Jan Kiszka
2011-09-20 21:25 ` Hervé Poussineau
2011-09-21 6:16 ` [Qemu-devel] [PATCH] Probe PCI existence Jan Kiszka
2011-09-23 4:23 ` Kevin O'Connor
2011-10-10 14:29 ` Gerd Hoffmann
2011-09-23 16:05 ` [Qemu-devel] [PATCH] isapc: give system address space when pci is disabled Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E778EB7.5010706@reactos.org \
--to=hpoussin@reactos.org \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).