From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46791) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5xRg-0004LL-QA for qemu-devel@nongnu.org; Tue, 20 Sep 2011 06:20:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R5xRf-0006Xy-Kb for qemu-devel@nongnu.org; Tue, 20 Sep 2011 06:20:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6267) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R5xRf-0006Xh-Dh for qemu-devel@nongnu.org; Tue, 20 Sep 2011 06:20:55 -0400 Message-ID: <4E7868FC.7040407@redhat.com> Date: Tue, 20 Sep 2011 13:20:44 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1315561022-25386-1-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1315561022-25386-1-git-send-email-stefanha@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] Make simpletrace work on Windows List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Jan Kiszka , qemu-devel@nongnu.org On 09/09/2011 12:37 PM, Stefan Hajnoczi wrote: > The 'simple' trace backend uses pthreads and does not work on Windows. These > patches switch from pthreads to glib so that the code builds on all platforms > supported by glib. > > Only one thing I'm unhappy about: the simpletrace write-out thread used to > block all signals. I have removed that code and don't expect glib to do it for > me. I'm not sure if there is a problem if signal handlers are invoked in the > write-out thread instead of a QEMU thread. Any thoughts? > Yes it's a problem when we block a signal completely and only process it with sigtimedwait(). -- error compiling committee.c: too many arguments to function