From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42225) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R60VA-0005eW-Ek for qemu-devel@nongnu.org; Tue, 20 Sep 2011 09:36:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R60V6-0007X7-1l for qemu-devel@nongnu.org; Tue, 20 Sep 2011 09:36:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34368) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R60V5-0007X3-OE for qemu-devel@nongnu.org; Tue, 20 Sep 2011 09:36:39 -0400 Message-ID: <4E789797.8010305@redhat.com> Date: Tue, 20 Sep 2011 15:39:35 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1314436348-28837-1-git-send-email-daniel@drv.nu> <2803ABD2-E8EA-4AE3-9AD1-21FC94DCB5BE@suse.de> In-Reply-To: <2803ABD2-E8EA-4AE3-9AD1-21FC94DCB5BE@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ahci: add port I/O index-data pair List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel@nongnu.org, Daniel Verkamp Am 28.08.2011 20:48, schrieb Alexander Graf: > > On 27.08.2011, at 04:12, Daniel Verkamp wrote: > >> Implement an I/O space index-data register pair as defined by the AHCI >> spec, including the corresponding SATA PCI capability and BAR. >> >> This allows real-mode code to access the AHCI registers; real-mode >> code cannot address the memory-mapped register space because it is >> beyond the first megabyte. > > Very nice patch! I'll check and compare with a real ICH-9 when I get back to .de, but I'd assume you also did that already ;). Once I checked that the IO region is set up similarly, I'll give you my ack. What's the status with review/testing of this patch, Alex? Is it ready to be merged, should I drop it or do you just need some more time? Kevin