From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:36279)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1R6136-0000DR-40
	for qemu-devel@nongnu.org; Tue, 20 Sep 2011 10:11:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1R6132-0006SZ-84
	for qemu-devel@nongnu.org; Tue, 20 Sep 2011 10:11:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:20533)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1R6131-0006SR-V7
	for qemu-devel@nongnu.org; Tue, 20 Sep 2011 10:11:44 -0400
Message-ID: <4E789F0C.1060405@redhat.com>
Date: Tue, 20 Sep 2011 16:11:24 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1316188834-13675-1-git-send-email-aliguori@us.ibm.com>	<1316188834-13675-5-git-send-email-aliguori@us.ibm.com>	<4E76F074.4030801@redhat.com>	<4E776D6D.2040702@codemonkey.ws>
	<4E78345E.5080300@redhat.com>	<4E788F57.40305@us.ibm.com>
	<4E78934C.4080308@redhat.com> <4E789B63.10703@us.ibm.com>
In-Reply-To: <4E789B63.10703@us.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 04/14] qdev: take ownership of id pointer
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Markus Armbruster <armbru@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>

   Hi,

>> Oh, and not
>> releasing the QemuOpts would also leak memory on each hot-unplug.
>
> If you look at my patch, opts is freed at the end of device_add so there
> is no leak.

Ah, ok.  Missed that.

cheers,
   Gerd