[Qemu-devel] [PATCH] qxl: Drop phread_yield on OOM

[Qemu-devel] [PATCH] qxl: Drop phread_yield on OOM

[Jan Kiszka]

This was only a best-effort attempt, by far not guaranteed to have an
effect. Drop it so that also no direct pthread usage remain in the
device model.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

Depends on the previous qxl patch I just sent.

 hw/qxl.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/hw/qxl.c b/hw/qxl.c
index 082b940..3e9052f 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -18,8 +18,6 @@
  * along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
-#include <pthread.h>
-
 #include "qemu-common.h"
 #include "qemu-timer.h"
 #include "qemu-queue.h"
@@ -1215,10 +1213,6 @@ async_common:
         if (!SPICE_RING_IS_EMPTY(&d->ram->release_ring)) {
             break;
         }
-        pthread_yield();
-        if (!SPICE_RING_IS_EMPTY(&d->ram->release_ring)) {
-            break;
-        }
         d->oom_running = 1;
         qxl_spice_oom(d);
         d->oom_running = 0;
-- 
1.7.3.4

Re: [Qemu-devel] [PATCH] qxl: Drop phread_yield on OOM

[Gerd Hoffmann]

On 09/20/11 17:21, Jan Kiszka wrote:
> This was only a best-effort attempt, by far not guaranteed to have an
> effect. Drop it so that also no direct pthread usage remain in the
> device model.
>
> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>

All three patches are fine.

I'll go queue it up in the spice queue when I'm back from vacation in 
2-3 weeks (unless they find their way upstream through a another tree 
meanwhile).

cheers,
   Gerd