From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:37623)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1R62Zt-0008QQ-I0
	for qemu-devel@nongnu.org; Tue, 20 Sep 2011 11:49:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1R62Zs-0003G3-96
	for qemu-devel@nongnu.org; Tue, 20 Sep 2011 11:49:45 -0400
Received: from mail-ww0-f53.google.com ([74.125.82.53]:42699)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1R62Zs-0003Fo-4h
	for qemu-devel@nongnu.org; Tue, 20 Sep 2011 11:49:44 -0400
Received: by wwg14 with SMTP id 14so833106wwg.10
	for <qemu-devel@nongnu.org>; Tue, 20 Sep 2011 08:49:43 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4E78B616.2090905@redhat.com>
Date: Tue, 20 Sep 2011 17:49:42 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1316524908.git.quintela@redhat.com>
	<26dc4cc40ec26fe309147639a46334ca393cb1b8.1316524908.git.quintela@redhat.com>
In-Reply-To: <26dc4cc40ec26fe309147639a46334ca393cb1b8.1316524908.git.quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 5/7] migration: add error handling to
	migrate_fd_put_notify().
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org, Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>

On 09/20/2011 03:24 PM, Juan Quintela wrote:
>
> diff --git a/migration.c b/migration.c
> index c56d29c..7f8928a 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -312,6 +312,9 @@ void migrate_fd_put_notify(void *opaque)
>
>       qemu_set_fd_handler2(s->fd, NULL, NULL, NULL, NULL);
>       qemu_file_put_notify(s->file);
> +    if (qemu_file_has_error(s->file)) {
> +        migrate_fd_error(s);
> +    }

Note this is testing QEMUFile's has_error, not QEMUBufferedFile's. 
Merging the two flags would be a good idea.

Paolo