From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33344) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R654a-0008CF-OZ for qemu-devel@nongnu.org; Tue, 20 Sep 2011 14:29:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R654Z-0006jl-DN for qemu-devel@nongnu.org; Tue, 20 Sep 2011 14:29:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13736) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R654Z-0006jf-3L for qemu-devel@nongnu.org; Tue, 20 Sep 2011 14:29:35 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p8KITY2O003198 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 20 Sep 2011 14:29:34 -0400 Message-ID: <4E78D516.7080803@redhat.com> Date: Tue, 20 Sep 2011 12:01:58 -0600 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [libvirt] [PATCH] qemu: Fix shutdown regression List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: libvir-list@redhat.com, QEMU Developers On 09/20/2011 11:39 AM, Jiri Denemark wrote: > The commit that prevents disk corruption on domain shutdown > (96fc4784177ecb70357518fa863442455e45ad0e) causes regression with QEMU > 0.14.* and 0.15.* because of a regression bug in QEMU that was fixed > only recently in QEMU git. With affected QEMU binaries, domains cannot > be shutdown properly and stay in a paused state. This patch tries to > avoid this by sending SIGKILL to 0.1[45].* QEMU processes. Though we > wait a bit more between sending SIGTERM and SIGKILL to reduce the > possibility of virtual disk corruption. > --- > src/qemu/qemu_capabilities.c | 7 +++++++ > src/qemu/qemu_capabilities.h | 1 + > src/qemu/qemu_process.c | 19 +++++++++++++------ > 3 files changed, 21 insertions(+), 6 deletions(-) ACK. But it would be nice if upstream qemu could give us a more reliable indication of whether the qemu SIGTERM bug is fixed, so that we don't corrupt data on a patched 0.14 or 0.15 qemu. That is, as part of fixing the bug in qemu, we should also update -help text or something similar, so that libvirt can avoid making decisions solely on version numbers. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org