From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40188) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R67oa-0003kJ-W8 for qemu-devel@nongnu.org; Tue, 20 Sep 2011 17:25:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R67oZ-0001hN-JP for qemu-devel@nongnu.org; Tue, 20 Sep 2011 17:25:16 -0400 Received: from smtp5-g21.free.fr ([212.27.42.5]:47095) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R67oZ-0001e0-0D for qemu-devel@nongnu.org; Tue, 20 Sep 2011 17:25:15 -0400 Message-ID: <4E7904AD.6040807@reactos.org> Date: Tue, 20 Sep 2011 23:25:01 +0200 From: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= MIME-Version: 1.0 References: <1316361891-8960-1-git-send-email-hpoussin@reactos.org> <4E76F5F2.7000204@siemens.com> <4E778EB7.5010706@reactos.org> <4E784E63.3050404@siemens.com> In-Reply-To: <4E784E63.3050404@siemens.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] isapc: give system address space when pci is disabled List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: "qemu-devel@nongnu.org" , Gerd Hoffmann Jan Kiszka a =C3=A9crit : > On 2011-09-19 20:49, Herv=C3=A9 Poussineau wrote: >> Jan Kiszka a =C3=A9crit : >>> On 2011-09-18 18:04, Herv=C3=A9 Poussineau wrote: >>>> Signed-off-by: Herv=C3=A9 Poussineau >>>> --- >>>> hw/pc_piix.c | 2 +- >>>> 1 files changed, 1 insertions(+), 1 deletions(-) >>>> >>>> diff --git a/hw/pc_piix.c b/hw/pc_piix.c >>>> index da6fa55..c0b8a3a 100644 >>>> --- a/hw/pc_piix.c >>>> +++ b/hw/pc_piix.c >>>> @@ -121,7 +121,7 @@ static void pc_init1(MemoryRegion *system_memory= , >>>> pc_memory_init(system_memory, >>>> kernel_filename, kernel_cmdline, initrd_file= name, >>>> below_4g_mem_size, above_4g_mem_size, >>>> - pci_memory, &ram_memory); >>>> + pci_enabled ? pci_memory : system_memory, &r= am_memory); >>>> } >>>> =20 >>>> if (!xen_enabled()) { >>> Makes sense. I guess we should rename 'pci_memory' inside pc_memory_i= nit >>> to reflect this - 'rom_memory'? >>> >>> But -M isapc still only gives me a black screen. Are there further fi= xes >>> required? >>> >> Yes, you also need to rollback pc-bios/bios.bin to previous version (i= e=20 >> 8b06c62ae48b67b320f7420dcd4854c5559e1532) >=20 > Did you already try to bisect that probable regression in SeaBIOS? >=20 Yes, I regtested the problem to this SeaBIOS commit: 01a5c8813b2e709809c07c5d7fab9d1c3ddb4989 is the first bad commit commit 01a5c8813b2e709809c07c5d7fab9d1c3ddb4989 Author: Gerd Hoffmann Date: Mon Jul 11 09:20:29 2011 +0200 pci: activate two-pass pci initialization code This patch actually enables the two-pass pci initialization and deactivates the old pci initialization bits. Signed-off-by: Gerd Hoffmann Binary is current qemu + this patch Command line is: qemu-system-i386 -M isapc -vga std Herv=C3=A9