From: Paolo Bonzini <pbonzini@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Alon Levy <alevy@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/6] Enable joinable POSIX threads
Date: Wed, 21 Sep 2011 09:16:54 +0200 [thread overview]
Message-ID: <4E798F66.4070809@redhat.com> (raw)
In-Reply-To: <3beaa0c559cd7f2df1299e7385a8997165c0f851.1316537591.git.jan.kiszka@siemens.com>
On 09/20/2011 06:53 PM, Jan Kiszka wrote:
> - qemu_thread_create(&thread_id, event_thread, card);
> - qemu_thread_create(&thread_id, handle_apdu_thread, card);
> + qemu_thread_create(&thread_id, event_thread, card, QEMU_THREAD_DETACHED);
> + qemu_thread_create(&thread_id, handle_apdu_thread, card,
> + QEMU_THREAD_DETACHED);
> return 0;
> }
I think these two should be joinable. Otherwise, you might be
destroying the apdu_thread_quit_mutex while the handle_apdu_thread
hasn't yet finished unlocking it (even though it already progressed
enough in qemu_mutex_destroy to release the main thread).
Anyhow, the bug is not introduced by your patch, so
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2011-09-21 7:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 16:53 [Qemu-devel] [PATCH 0/6] Spread the use of QEMU threading & locking API Jan Kiszka
2011-09-20 16:53 ` [Qemu-devel] [PATCH 1/6] Enable joinable POSIX threads Jan Kiszka
2011-09-21 7:16 ` Paolo Bonzini [this message]
2011-09-21 13:40 ` Kevin Wolf
2011-09-21 13:38 ` Paolo Bonzini
2011-09-20 16:53 ` [Qemu-devel] [PATCH 2/6] Introduce qemu_cond_timedwait Jan Kiszka
2011-09-20 18:22 ` Paolo Bonzini
2011-09-20 19:02 ` [Qemu-devel] [PATCH v2 2/6] Introduce qemu_cond_timedwait for POSIX Jan Kiszka
2011-09-20 16:53 ` [Qemu-devel] [PATCH 3/6] Switch POSIX compat AIO to QEMU abstractions Jan Kiszka
2011-09-21 13:57 ` Kevin Wolf
2011-09-21 14:02 ` Jan Kiszka
2011-09-21 14:11 ` Kevin Wolf
2011-09-20 16:53 ` [Qemu-devel] [PATCH 4/6] Switch compatfd to QEMU thread Jan Kiszka
2011-09-20 16:53 ` [Qemu-devel] [PATCH 5/6] audio: Use QEMU threads & synchronization Jan Kiszka
2011-09-20 16:53 ` [Qemu-devel] [PATCH 6/6] audio: Switch coreaudio to QemuMutex Jan Kiszka
2011-09-26 7:58 ` Andreas Färber
2011-09-26 8:06 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E798F66.4070809@redhat.com \
--to=pbonzini@redhat.com \
--cc=alevy@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).