From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43020) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6HDx-0006b1-NT for qemu-devel@nongnu.org; Wed, 21 Sep 2011 03:28:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R6HDw-0002T6-2m for qemu-devel@nongnu.org; Wed, 21 Sep 2011 03:28:05 -0400 Received: from speedy.comstyle.com ([206.51.28.2]:42617 helo=mail.comstyle.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6HDw-0002Sq-0F for qemu-devel@nongnu.org; Wed, 21 Sep 2011 03:28:04 -0400 Message-ID: <4E7991FE.9010204@comstyle.com> Date: Wed, 21 Sep 2011 03:27:58 -0400 From: Brad MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Tree broken by nbd: support feature negotiation commit. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel Cc: Kevin Wolf , Paolo Bonzini The following commit.. nbd: support feature negotiation nbd supports writing flags in bytes 24...27 of the header, and uses that for the read-only flag. Add support for it in qemu-nbd. breaks the tree on what looks like anything but Linux. Besides the obvious issue.. nbd.c:443: error: conflicting types for 'nbd_init' nbd.h:71: error: previous declaration of 'nbd_init' was here The changing of #ifndef _WIN32 to #ifdef __linux__ in nbd.c also looks questionable to me. -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.