From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40292) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6HID-0008My-Uf for qemu-devel@nongnu.org; Wed, 21 Sep 2011 03:32:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R6HI2-0003t4-TI for qemu-devel@nongnu.org; Wed, 21 Sep 2011 03:32:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61615) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6HI2-0003rl-Lv for qemu-devel@nongnu.org; Wed, 21 Sep 2011 03:32:18 -0400 Message-ID: <4E7992FD.4060207@redhat.com> Date: Wed, 21 Sep 2011 09:32:13 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <4E7991FE.9010204@comstyle.com> In-Reply-To: <4E7991FE.9010204@comstyle.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Tree broken by nbd: support feature negotiation commit. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Brad Cc: Kevin Wolf , qemu-devel On 09/21/2011 09:27 AM, Brad wrote: > Besides the obvious issue.. > > nbd.c:443: error: conflicting types for 'nbd_init' > nbd.h:71: error: previous declaration of 'nbd_init' was here Oops, thanks for pointing it out to me. > The changing of #ifndef _WIN32 to #ifdef __linux__ in nbd.c also > looks questionable to me. It is not portable code, and (unlike the rest of qemu-nbd and the block/nbd.c protocol) not meant to be portable. Are BLKROSET (defined in linux/fs.h) and the whole set of NBD ioctls available under OpenBSD? Paolo