* [Qemu-devel] [PATCH] remove duplicate typedef
@ 2011-09-21 9:16 Paolo Bonzini
2011-09-21 10:07 ` Stefan Hajnoczi
0 siblings, 1 reply; 4+ messages in thread
From: Paolo Bonzini @ 2011-09-21 9:16 UTC (permalink / raw)
To: qemu-devel; +Cc: blauwirbel
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
This is failing with some versions of GCC but not others,
apparently.
qemu-common.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/qemu-common.h b/qemu-common.h
index ef9a2bb..404c421 100644
--- a/qemu-common.h
+++ b/qemu-common.h
@@ -18,7 +18,6 @@ typedef struct DeviceState DeviceState;
struct Monitor;
typedef struct Monitor Monitor;
-typedef struct QEMUSGList QEMUSGList;
/* we put basic includes here to avoid repeating them in device drivers */
#include <stdlib.h>
--
1.7.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] remove duplicate typedef
2011-09-21 9:16 [Qemu-devel] [PATCH] remove duplicate typedef Paolo Bonzini
@ 2011-09-21 10:07 ` Stefan Hajnoczi
2011-09-21 10:14 ` Paolo Bonzini
2011-09-21 10:15 ` Kevin Wolf
0 siblings, 2 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2011-09-21 10:07 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: blauwirbel, qemu-devel
On Wed, Sep 21, 2011 at 10:16 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> diff --git a/qemu-common.h b/qemu-common.h
> index ef9a2bb..404c421 100644
> --- a/qemu-common.h
> +++ b/qemu-common.h
> @@ -18,7 +18,6 @@ typedef struct DeviceState DeviceState;
>
> struct Monitor;
> typedef struct Monitor Monitor;
> -typedef struct QEMUSGList QEMUSGList;
Weird I don't have this in my tree. There's nothing to remove but a
quick probe of history also doesn't show it ever being there.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] remove duplicate typedef
2011-09-21 10:07 ` Stefan Hajnoczi
@ 2011-09-21 10:14 ` Paolo Bonzini
2011-09-21 10:15 ` Kevin Wolf
1 sibling, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2011-09-21 10:14 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: blauwirbel, qemu-devel
On 09/21/2011 12:07 PM, Stefan Hajnoczi wrote:
> On Wed, Sep 21, 2011 at 10:16 AM, Paolo Bonzini<pbonzini@redhat.com> wrote:
>> diff --git a/qemu-common.h b/qemu-common.h
>> index ef9a2bb..404c421 100644
>> --- a/qemu-common.h
>> +++ b/qemu-common.h
>> @@ -18,7 +18,6 @@ typedef struct DeviceState DeviceState;
>>
>> struct Monitor;
>> typedef struct Monitor Monitor;
>> -typedef struct QEMUSGList QEMUSGList;
>
> Weird I don't have this in my tree. There's nothing to remove but a
> quick probe of history also doesn't show it ever being there.
Doubly weird. I have it in my development branch, but not in the
integration branch from which I sent patches to Kevin. So it didn't
reach upstream indeed.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] remove duplicate typedef
2011-09-21 10:07 ` Stefan Hajnoczi
2011-09-21 10:14 ` Paolo Bonzini
@ 2011-09-21 10:15 ` Kevin Wolf
1 sibling, 0 replies; 4+ messages in thread
From: Kevin Wolf @ 2011-09-21 10:15 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: blauwirbel, Paolo Bonzini, qemu-devel
Am 21.09.2011 12:07, schrieb Stefan Hajnoczi:
> On Wed, Sep 21, 2011 at 10:16 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> diff --git a/qemu-common.h b/qemu-common.h
>> index ef9a2bb..404c421 100644
>> --- a/qemu-common.h
>> +++ b/qemu-common.h
>> @@ -18,7 +18,6 @@ typedef struct DeviceState DeviceState;
>>
>> struct Monitor;
>> typedef struct Monitor Monitor;
>> -typedef struct QEMUSGList QEMUSGList;
>
> Weird I don't have this in my tree. There's nothing to remove but a
> quick probe of history also doesn't show it ever being there.
One of Paolo's block patches added it, I dropped it before sending the
pull request (and looks like I forgot to send a mail about it). So I
guess he's on his development branch and the rebase left a patch with
this hunk in place.
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-09-21 10:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-21 9:16 [Qemu-devel] [PATCH] remove duplicate typedef Paolo Bonzini
2011-09-21 10:07 ` Stefan Hajnoczi
2011-09-21 10:14 ` Paolo Bonzini
2011-09-21 10:15 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).