From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48459) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6K1Z-0001yx-Ju for qemu-devel@nongnu.org; Wed, 21 Sep 2011 06:27:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R6K1Y-0006ai-Dy for qemu-devel@nongnu.org; Wed, 21 Sep 2011 06:27:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33128) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6K1Y-0006aU-2S for qemu-devel@nongnu.org; Wed, 21 Sep 2011 06:27:28 -0400 Message-ID: <4E79BCBB.1010800@redhat.com> Date: Wed, 21 Sep 2011 12:30:19 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <4E78D516.7080803@redhat.com> In-Reply-To: <4E78D516.7080803@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [libvirt] [PATCH] qemu: Fix shutdown regression List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: libvir-list@redhat.com, "Justin M. Forbes" , QEMU Developers Am 20.09.2011 20:01, schrieb Eric Blake: > On 09/20/2011 11:39 AM, Jiri Denemark wrote: >> The commit that prevents disk corruption on domain shutdown >> (96fc4784177ecb70357518fa863442455e45ad0e) causes regression with QEMU >> 0.14.* and 0.15.* because of a regression bug in QEMU that was fixed >> only recently in QEMU git. With affected QEMU binaries, domains cannot >> be shutdown properly and stay in a paused state. This patch tries to >> avoid this by sending SIGKILL to 0.1[45].* QEMU processes. Though we >> wait a bit more between sending SIGTERM and SIGKILL to reduce the >> possibility of virtual disk corruption. I really think libvirt should never SIGKILL qemu unless it's explicitly told so. Management tools should try to ask the user before doing so. Killing qemu with SIGKILL is never safe. >> --- >> src/qemu/qemu_capabilities.c | 7 +++++++ >> src/qemu/qemu_capabilities.h | 1 + >> src/qemu/qemu_process.c | 19 +++++++++++++------ >> 3 files changed, 21 insertions(+), 6 deletions(-) > > ACK. But it would be nice if upstream qemu could give us a more > reliable indication of whether the qemu SIGTERM bug is fixed, so that we > don't corrupt data on a patched 0.14 or 0.15 qemu. 0.14 shouldn't have this bug, but it looks like 0.15 has it. Justin, can you cherry-pick d9389b96 and 941f511a into stable-0.15 in order to fix -no-shutdown? Kevin