From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Devin Nakamura <devin122@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/6] qed: add qed_find_cluster_sync()
Date: Wed, 21 Sep 2011 15:02:25 +0200 [thread overview]
Message-ID: <4E79E061.7070108@redhat.com> (raw)
In-Reply-To: <CAJSP0QUDCnH08e7sA15ZeAkXEUY9cwuGKnPiWUo9LYYow9EEFA@mail.gmail.com>
Am 21.09.2011 14:45, schrieb Stefan Hajnoczi:
> On Mon, Sep 12, 2011 at 3:47 PM, Devin Nakamura <devin122@gmail.com> wrote:
> /* See qed_find_cluster(), especially how request->l2_table reference
> count works */
>> +int qed_find_cluster_sync(BDRVQEDState *s, QEDRequest *request, uint64_t pos,
>> + size_t len, uint64_t *offset,
>> + size_t *contiguous_bytes)
>
> If you respin please add a comment like the one above. It's easy to
> forget that this function grabs the l2_table and gives you a
> reference. Let's put a warning in place.
Fixing the name of the function is probably better than adding a comment
to each user.
Kevin
next prev parent reply other threads:[~2011-09-21 12:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-12 14:47 [Qemu-devel] [PATCH 0/6] QED block conversion Devin Nakamura
2011-09-12 14:47 ` [Qemu-devel] [PATCH 1/6] qed: add qed_find_cluster_sync() Devin Nakamura
2011-09-21 12:45 ` Stefan Hajnoczi
2011-09-21 13:02 ` Kevin Wolf [this message]
2011-09-12 14:47 ` [Qemu-devel] [PATCH 2/6] qed: add bdrv_qed_get_conversion_options() Devin Nakamura
2011-09-12 14:47 ` [Qemu-devel] [PATCH 3/6] qed: add open_conversion_target() Devin Nakamura
2011-09-20 9:21 ` Kevin Wolf
2011-09-21 12:37 ` Stefan Hajnoczi
2011-09-20 8:38 ` [Qemu-devel] [PATCH 0/6] QED block conversion Kevin Wolf
2011-09-20 9:58 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E79E061.7070108@redhat.com \
--to=kwolf@redhat.com \
--cc=devin122@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).