From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:57963)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1R6MOm-0003GU-CA
	for qemu-devel@nongnu.org; Wed, 21 Sep 2011 08:59:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1R6MOg-00054R-6s
	for qemu-devel@nongnu.org; Wed, 21 Sep 2011 08:59:36 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36012)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1R6MOf-00054L-Sk
	for qemu-devel@nongnu.org; Wed, 21 Sep 2011 08:59:30 -0400
Message-ID: <4E79E061.7070108@redhat.com>
Date: Wed, 21 Sep 2011 15:02:25 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1315838844-14307-1-git-send-email-devin122@gmail.com>
	<1315838844-14307-2-git-send-email-devin122@gmail.com>
	<CAJSP0QUDCnH08e7sA15ZeAkXEUY9cwuGKnPiWUo9LYYow9EEFA@mail.gmail.com>
In-Reply-To: <CAJSP0QUDCnH08e7sA15ZeAkXEUY9cwuGKnPiWUo9LYYow9EEFA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/6] qed: add qed_find_cluster_sync()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Devin Nakamura <devin122@gmail.com>, qemu-devel@nongnu.org

Am 21.09.2011 14:45, schrieb Stefan Hajnoczi:
> On Mon, Sep 12, 2011 at 3:47 PM, Devin Nakamura <devin122@gmail.com> wrote:
> /* See qed_find_cluster(), especially how request->l2_table reference
> count works */
>> +int qed_find_cluster_sync(BDRVQEDState *s, QEDRequest *request, uint64_t pos,
>> +                          size_t len, uint64_t *offset,
>> +                          size_t *contiguous_bytes)
> 
> If you respin please add a comment like the one above.  It's easy to
> forget that this function grabs the l2_table and gives you a
> reference.  Let's put a warning in place.

Fixing the name of the function is probably better than adding a comment
to each user.

Kevin