From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47332) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6Z1i-0005D8-FY for qemu-devel@nongnu.org; Wed, 21 Sep 2011 22:28:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R6Z1h-00051b-Bz for qemu-devel@nongnu.org; Wed, 21 Sep 2011 22:28:38 -0400 Received: from e28smtp06.in.ibm.com ([122.248.162.6]:32848) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6Z1g-00051T-Op for qemu-devel@nongnu.org; Wed, 21 Sep 2011 22:28:37 -0400 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by e28smtp06.in.ibm.com (8.14.4/8.13.1) with ESMTP id p8M2SXJ1031482 for ; Thu, 22 Sep 2011 07:58:33 +0530 Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p8M2SVi24100326 for ; Thu, 22 Sep 2011 07:58:33 +0530 Received: from d28av01.in.ibm.com (loopback [127.0.0.1]) by d28av01.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p8M2SV9W025005 for ; Thu, 22 Sep 2011 07:58:31 +0530 Message-ID: <4E7A9D2E.20402@linux.vnet.ibm.com> Date: Thu, 22 Sep 2011 10:27:58 +0800 From: Lei Li MIME-Version: 1.0 References: <4E7A9153.9030905@linux.vnet.ibm.com> <20110922015833.GA11618@cs.nctu.edu.tw> In-Reply-To: <20110922015833.GA11618@cs.nctu.edu.tw> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] TB chaining List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?6Zmz6Z+L5Lu7?= Cc: qemu-devel , Xin Tong On 09/22/2011 09:58 AM, =E9=99=B3=E9=9F=8B=E4=BB=BB wrote: >> /* list of TBs jumping to this one. This is a circular list usin= g >> the two least significant bits of the pointers to tell what i= s >> the next pointer: 0 =3D jmp_next[0], 1 =3D jmp_next[1], 2 =3D >> jmp_first */ >> struct TranslationBlock *jmp_next[2]; >> struct TranslationBlock *jmp_first; > After tracing the code, I found the comment might be wrong. > For example, if we link tb1 to tb2, i.e., tb1 -> tb2. Then > "tb1->jmp_next[n] =3D tb2" and "tb2->jmp_first =3D tb1" (roughly > speaking). I'm not sure if I misunderstand the comment "list > of TBs jumping to this one", or it is just wrong. Well, the comment is from source code. I don't catch why you think "list of TBS jumping to this one" is wrong. My understand is that TB chain be used forreduce switch from the trans= lation cache to the guest code. It will be a circular list if there is no inte= rrupt or exceptional. At mean while, it's just the date related to TB chain in TB struct, it's not about process of how TB chain work. > Regards, > chenwj > --=20 Lei