From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:57319)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wdongxu@linux.vnet.ibm.com>) id 1R6bWx-0007Q6-4E
	for qemu-devel@nongnu.org; Thu, 22 Sep 2011 01:09:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wdongxu@linux.vnet.ibm.com>) id 1R6bWv-0003Db-VN
	for qemu-devel@nongnu.org; Thu, 22 Sep 2011 01:09:03 -0400
Received: from e28smtp05.in.ibm.com ([122.248.162.5]:47390)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wdongxu@linux.vnet.ibm.com>) id 1R6bWv-0003DS-3Q
	for qemu-devel@nongnu.org; Thu, 22 Sep 2011 01:09:01 -0400
Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62])
	by e28smtp05.in.ibm.com (8.14.4/8.13.1) with ESMTP id p8M58vcn002400
	for <qemu-devel@nongnu.org>; Thu, 22 Sep 2011 10:38:57 +0530
Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63])
	by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p8M58uKN2044104
	for <qemu-devel@nongnu.org>; Thu, 22 Sep 2011 10:38:56 +0530
Received: from d28av01.in.ibm.com (loopback [127.0.0.1])
	by d28av01.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	p8M58u4N007911
	for <qemu-devel@nongnu.org>; Thu, 22 Sep 2011 10:38:56 +0530
Message-ID: <4E7AC2CB.8010603@linux.vnet.ibm.com>
Date: Thu, 22 Sep 2011 13:08:27 +0800
From: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <4E78ADD9.30904@siemens.com>
In-Reply-To: <4E78ADD9.30904@siemens.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] spice: Convert core to QEMU thread API
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: wdongxu@cn.ibm.com, qemu-devel <qemu-devel@nongnu.org>

Tested, it is compatible with checkpatch.pl and can work well.
> No need to use pthread directly, we have proper abstractions for
> identity checking.
>
> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
> ---
>   ui/spice-core.c |    8 ++++----
>   1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/ui/spice-core.c b/ui/spice-core.c
> index 3cbc721..afdf82e 100644
> --- a/ui/spice-core.c
> +++ b/ui/spice-core.c
> @@ -19,10 +19,10 @@
>   #include<spice-experimental.h>
>
>   #include<netdb.h>
> -#include<pthread.h>
>
>   #include "qemu-common.h"
>   #include "qemu-spice.h"
> +#include "qemu-thread.h"
>   #include "qemu-timer.h"
>   #include "qemu-queue.h"
>   #include "qemu-x509.h"
> @@ -45,7 +45,7 @@ static char *auth_passwd;
>   static time_t auth_expires = TIME_MAX;
>   int using_spice = 0;
>
> -static pthread_t me;
> +static QemuThread me;
>
>   struct SpiceTimer {
>       QEMUTimer *timer;
> @@ -229,7 +229,7 @@ static void channel_event(int event, SpiceChannelEventInfo *info)
>        * thread and grab the iothread lock if so before calling qemu
>        * functions.
>        */
> -    bool need_lock = !pthread_equal(me, pthread_self());
> +    bool need_lock = !qemu_thread_is_self(&me);
>       if (need_lock) {
>           qemu_mutex_lock_iothread();
>       }
> @@ -503,7 +503,7 @@ void qemu_spice_init(void)
>       spice_image_compression_t compression;
>       spice_wan_compression_t wan_compr;
>
> -    me = pthread_self();
> +    qemu_thread_get_self(&me);
>
>      if (!opts) {
>           return;