From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R74s4-0001FS-M4 for qemu-devel@nongnu.org; Fri, 23 Sep 2011 08:28:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R74s3-0006cc-LW for qemu-devel@nongnu.org; Fri, 23 Sep 2011 08:28:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11219) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R74s3-0006cS-EW for qemu-devel@nongnu.org; Fri, 23 Sep 2011 08:28:47 -0400 Message-ID: <4E7C7C2D.5000102@redhat.com> Date: Fri, 23 Sep 2011 14:31:41 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1316777156-21477-1-git-send-email-freddy77@gmail.com> In-Reply-To: <1316777156-21477-1-git-send-email-freddy77@gmail.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qcow2: fix 028 iotest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Frediano Ziglio Cc: qemu-devel@nongnu.org Am 23.09.2011 13:25, schrieb Frediano Ziglio: > This fix bound check bug accessing last cluster if image size is not > cluster aligned caused by "Unlock during COW" patch. > > Signed-off-by: Frediano Ziglio I'm considering a solution like this, but I'm not completely happy with it. Maybe the more correct thing would be to restrict the request to the allowed size in copy_sectors. Anyway, if I decide that this is the way to go, I'll merge this fix into my patch along with a notice in the commit log (better than two independent commits in terms of bisectablity). Kevin