From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R765N-0006L9-II for qemu-devel@nongnu.org; Fri, 23 Sep 2011 09:46:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R765M-0007mm-8r for qemu-devel@nongnu.org; Fri, 23 Sep 2011 09:46:37 -0400 Received: from mail-ww0-f53.google.com ([74.125.82.53]:58370) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R765L-0007ma-Sw for qemu-devel@nongnu.org; Fri, 23 Sep 2011 09:46:36 -0400 Received: by wwg14 with SMTP id 14so3178616wwg.10 for ; Fri, 23 Sep 2011 06:46:35 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4E7C8DB9.1070204@redhat.com> Date: Fri, 23 Sep 2011 15:46:33 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <28d7c0af10d91b0428ef81f4e48d3e641d3dc99c.1316781876.git.quintela@redhat.com> In-Reply-To: <28d7c0af10d91b0428ef81f4e48d3e641d3dc99c.1316781876.git.quintela@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/11] migration: don't "write" when migration is not active List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org On 09/23/2011 02:50 PM, Juan Quintela wrote: > If migration is not active, just ignore writes. > > [Based on Daniel Berrange suggestion] > > Signed-off-by: Juan Quintela > --- > migration.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/migration.c b/migration.c > index 0b284ff..755b96b 100644 > --- a/migration.c > +++ b/migration.c > @@ -323,6 +323,10 @@ ssize_t migrate_fd_put_buffer(void *opaque, const void *data, size_t size) > FdMigrationState *s = opaque; > ssize_t ret; > > + if (s->state != MIG_STATE_ACTIVE) { > + return -EIO; > + } > + > do { > ret = s->write(s, data, size); > } while (ret == -1&& ((s->get_error(s)) == EINTR)); Acked-by: Paolo Bonzini