From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47466) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R76zG-0002W8-Pd for qemu-devel@nongnu.org; Fri, 23 Sep 2011 10:44:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R76zF-00037W-Nk for qemu-devel@nongnu.org; Fri, 23 Sep 2011 10:44:22 -0400 Received: from mail-iy0-f173.google.com ([209.85.210.173]:65213) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R76zF-00037P-Is for qemu-devel@nongnu.org; Fri, 23 Sep 2011 10:44:21 -0400 Received: by iagf6 with SMTP id f6so4810043iag.4 for ; Fri, 23 Sep 2011 07:44:20 -0700 (PDT) Message-ID: <4E7C9B41.2090600@codemonkey.ws> Date: Fri, 23 Sep 2011 09:44:17 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1316165105-18315-1-git-send-email-kraxel@redhat.com> In-Reply-To: <1316165105-18315-1-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qdev: print bus properties too List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: ddutile@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com On 09/16/2011 04:25 AM, Gerd Hoffmann wrote: > Make qdev_device_help print both device and bus properties. > Helps libvirt to figure whenever bus properties such as > PCI.multifunction are supported present or not. > > Signed-off-by: Gerd Hoffmann Applied. Thanks. Regards, Anthony Liguori > --- > hw/qdev.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/hw/qdev.c b/hw/qdev.c > index c463c52..a223d41 100644 > --- a/hw/qdev.c > +++ b/hw/qdev.c > @@ -207,6 +207,12 @@ int qdev_device_help(QemuOpts *opts) > } > error_printf("%s.%s=%s\n", info->name, prop->name, prop->info->name); > } > + for (prop = info->bus_info->props; prop&& prop->name; prop++) { > + if (!prop->info->parse) { > + continue; /* no way to set it, don't show */ > + } > + error_printf("%s.%s=%s\n", info->name, prop->name, prop->info->name); > + } > return 1; > } >