From: Anthony Liguori <aliguori@us.ibm.com>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH 2/2] build: fix race with creating qapi-generated
Date: Fri, 23 Sep 2011 10:52:47 -0500 [thread overview]
Message-ID: <4E7CAB4F.8030607@us.ibm.com> (raw)
In-Reply-To: <1315438852-18029-2-git-send-email-mdroth@linux.vnet.ibm.com>
On 09/07/2011 06:40 PM, Michael Roth wrote:
> Since qapi-generated/ is a global QEMU include path, we need to make
> sure it is created before anything is compiled, so do this in the
> configure phase rather than via the Makefile.
>
> Signed-off-by: Michael Roth<mdroth@linux.vnet.ibm.com>
Applied for real this time :-) Thanks.
Regards,
Anthony Liguori
> ---
> configure | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index c3044c7..0794f31 100755
> --- a/configure
> +++ b/configure
> @@ -3612,7 +3612,7 @@ DIRS="tests tests/cris slirp audio block net pc-bios/optionrom"
> DIRS="$DIRS pc-bios/spapr-rtas"
> DIRS="$DIRS roms/seabios roms/vgabios"
> DIRS="$DIRS fsdev ui"
> -DIRS="$DIRS qapi"
> +DIRS="$DIRS qapi qapi-generated"
> DIRS="$DIRS qga trace"
> FILES="Makefile tests/Makefile"
> FILES="$FILES tests/cris/Makefile tests/cris/.gdbinit"
next prev parent reply other threads:[~2011-09-23 15:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 23:40 [Qemu-devel] [PATCH 1/2] build: fix missing trace dep on GENERATED_HEADERS Michael Roth
2011-09-07 23:40 ` [Qemu-devel] [PATCH 2/2] build: fix race with creating qapi-generated Michael Roth
2011-09-09 18:35 ` Anthony Liguori
2011-09-23 15:52 ` Anthony Liguori [this message]
2011-09-08 9:35 ` [Qemu-devel] [PATCH 1/2] build: fix missing trace dep on GENERATED_HEADERS Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E7CAB4F.8030607@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=agraf@suse.de \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).