From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57568) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R78KD-0004q9-Gs for qemu-devel@nongnu.org; Fri, 23 Sep 2011 12:10:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R78KB-0004El-Ii for qemu-devel@nongnu.org; Fri, 23 Sep 2011 12:10:05 -0400 Received: from e5.ny.us.ibm.com ([32.97.182.145]:52966) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R78KB-0004Dh-Fv for qemu-devel@nongnu.org; Fri, 23 Sep 2011 12:10:03 -0400 Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237]) by e5.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p8NFcqvg031303 for ; Fri, 23 Sep 2011 11:38:52 -0400 Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p8NG9gTZ138842 for ; Fri, 23 Sep 2011 12:09:43 -0400 Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p8NG8SC6020556 for ; Fri, 23 Sep 2011 10:08:29 -0600 Message-ID: <4E7CAE99.7050300@us.ibm.com> Date: Fri, 23 Sep 2011 11:06:49 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1316683575-31577-1-git-send-email-freddy77@gmail.com> In-Reply-To: <1316683575-31577-1-git-send-email-freddy77@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] core: remove qemu_service_io List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Frediano Ziglio Cc: qemu-devel@nongnu.org, Christoph Hellwig , Alexander Graf , Paul Brook On 09/22/2011 04:26 AM, Frediano Ziglio wrote: > qemu_service_io was mainly an alias to qemu_notify_event, > currently used only by PPC for timer hack, so call > qemu_notify_event directly. > > Signed-off-by: Frediano Ziglio Applied. Thanks. Regards, Anthony Liguori > --- > arch_init.c | 5 ----- > qemu-common.h | 3 --- > qemu-tool.c | 4 ---- > target-ppc/kvm_ppc.c | 2 +- > 4 files changed, 1 insertions(+), 13 deletions(-) > > diff --git a/arch_init.c b/arch_init.c > index 9a5a0e3..a6c69c7 100644 > --- a/arch_init.c > +++ b/arch_init.c > @@ -459,11 +459,6 @@ int ram_load(QEMUFile *f, void *opaque, int version_id) > return 0; > } > > -void qemu_service_io(void) > -{ > - qemu_notify_event(); > -} > - > #ifdef HAS_AUDIO > struct soundhw { > const char *name; > diff --git a/qemu-common.h b/qemu-common.h > index 404c421..5e87bdf 100644 > --- a/qemu-common.h > +++ b/qemu-common.h > @@ -276,9 +276,6 @@ void cpu_exec_init_all(void); > void cpu_save(QEMUFile *f, void *opaque); > int cpu_load(QEMUFile *f, void *opaque, int version_id); > > -/* Force QEMU to stop what it's doing and service IO */ > -void qemu_service_io(void); > - > /* Force QEMU to process pending events */ > void qemu_notify_event(void); > > diff --git a/qemu-tool.c b/qemu-tool.c > index eb89fe0..e9f7fe1 100644 > --- a/qemu-tool.c > +++ b/qemu-tool.c > @@ -29,10 +29,6 @@ struct QEMUBH > void *opaque; > }; > > -void qemu_service_io(void) > -{ > -} > - > Monitor *cur_mon; > > int monitor_cur_is_qmp(void) > diff --git a/target-ppc/kvm_ppc.c b/target-ppc/kvm_ppc.c > index 867dc1d..c031fcb 100644 > --- a/target-ppc/kvm_ppc.c > +++ b/target-ppc/kvm_ppc.c > @@ -88,7 +88,7 @@ void kvmppc_fdt_update(void *fdt) > > static void kvmppc_timer_hack(void *opaque) > { > - qemu_service_io(); > + qemu_notify_event(); > qemu_mod_timer(kvmppc_timer, qemu_get_clock_ns(vm_clock) + kvmppc_timer_rate); > } >