From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:51254)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1R78Ug-0001vS-Br
	for qemu-devel@nongnu.org; Fri, 23 Sep 2011 12:20:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1R78Ue-0006Su-JA
	for qemu-devel@nongnu.org; Fri, 23 Sep 2011 12:20:54 -0400
Received: from mail-gy0-f173.google.com ([209.85.160.173]:49282)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1R78Ue-0006Sq-Gn
	for qemu-devel@nongnu.org; Fri, 23 Sep 2011 12:20:52 -0400
Received: by gye5 with SMTP id 5so3401282gye.4
	for <qemu-devel@nongnu.org>; Fri, 23 Sep 2011 09:20:51 -0700 (PDT)
Message-ID: <4E7CB1E0.20101@codemonkey.ws>
Date: Fri, 23 Sep 2011 11:20:48 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <20110921154221.27648.63402.stgit@ginnungagap.bsc.es>
In-Reply-To: <20110921154221.27648.63402.stgit@ginnungagap.bsc.es>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 1/3] Make 'qemu_init_vcpu' a function
 (instead of a macro)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?TGx1w61zIFZpbGFub3Zh?= <vilanova@ac.upc.edu>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@gmail.com>

On 09/21/2011 10:42 AM, Lluís Vilanova wrote:
> Implementation with 'CONFIG_USER_ONLY' is moved into new file 'cpus-user.c'.
>
> Signed-off-by: Lluís Vilanova<vilanova@ac.upc.edu>
> ---
>   Makefile.objs |    1 +
>   cpus-user.c   |    8 ++++++++
>   qemu-common.h |    4 ----
>   3 files changed, 9 insertions(+), 4 deletions(-)
>   create mode 100644 cpus-user.c
>
> diff --git a/Makefile.objs b/Makefile.objs
> index 1c65087..c94abd9 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -177,6 +177,7 @@ user-obj-y =
>   user-obj-y += envlist.o path.o
>   user-obj-y += tcg-runtime.o host-utils.o
>   user-obj-y += cutils.o cache-utils.o
> +user-obj-y += cpus-user.o
>   user-obj-y += $(trace-obj-y)
>
>   ######################################################################
> diff --git a/cpus-user.c b/cpus-user.c
> new file mode 100644
> index 0000000..c1e5e58
> --- /dev/null
> +++ b/cpus-user.c
> @@ -0,0 +1,8 @@
> +/* Implementation of routines in "cpus.c" when compiling for CONFIG_USER_ONLY */
> +
> +#include "qemu-common.h"
> +
> +
> +void qemu_init_vcpu(void *env)
> +{
> +}

New files need a copyright and license.

Regards,

Anthony Liguori

> diff --git a/qemu-common.h b/qemu-common.h
> index 404c421..7cda162 100644
> --- a/qemu-common.h
> +++ b/qemu-common.h
> @@ -296,11 +296,7 @@ struct qemu_work_item {
>       int done;
>   };
>
> -#ifdef CONFIG_USER_ONLY
> -#define qemu_init_vcpu(env) do { } while (0)
> -#else
>   void qemu_init_vcpu(void *env);
> -#endif
>
>   typedef struct QEMUIOVector {
>       struct iovec *iov;
>
>
>