From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41232) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R7Aq5-0007J3-JU for qemu-devel@nongnu.org; Fri, 23 Sep 2011 14:51:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R7Aq3-0000PN-PL for qemu-devel@nongnu.org; Fri, 23 Sep 2011 14:51:09 -0400 Received: from e1.ny.us.ibm.com ([32.97.182.141]:39557) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R7Aq3-0000PH-MO for qemu-devel@nongnu.org; Fri, 23 Sep 2011 14:51:07 -0400 Received: from /spool/local by us.ibm.com with XMail ESMTP for from ; Fri, 23 Sep 2011 14:50:34 -0400 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p8NIoW8i164382 for ; Fri, 23 Sep 2011 14:50:32 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p8NIoWY6018015 for ; Fri, 23 Sep 2011 15:50:32 -0300 Message-ID: <4E7CD4F7.3020806@us.ibm.com> Date: Fri, 23 Sep 2011 13:50:31 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1316184016-3239-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1316184016-3239-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Makefile: Remove 'tarbin' target List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, patches@linaro.org On 09/16/2011 09:40 AM, Peter Maydell wrote: > Remove the 'tarbin' target -- it isn't used as part of the official > QEMU release process, and it's out of date (various new bios files > were never added to its list of files). It's better not to provide > it at all than to have a broken makefile target we never use or test. > > (Creating a tarball by just pulling in binaries that have been installed > directly to the system you're running the build on is a bad idea anyway: > the better way to create a binary tarball would be just to install to > a temporary DESTDIR and then tar up that.) > > Signed-off-by: Peter Maydell Applied. Thanks. Regards, Anthony Liguori > --- > Rebased against current master. > > Makefile | 36 ------------------------------------ > 1 files changed, 0 insertions(+), 36 deletions(-) > > diff --git a/Makefile b/Makefile > index 57cc399..9ce0f9d 100644 > --- a/Makefile > +++ b/Makefile > @@ -368,41 +368,5 @@ tar: > cd /tmp&& tar zcvf ~/$(FILE).tar.gz $(FILE) --exclude CVS --exclude .git --exclude .svn > rm -rf /tmp/$(FILE) > > -SYSTEM_TARGETS=$(filter %-softmmu,$(TARGET_DIRS)) > -SYSTEM_PROGS=$(patsubst %-softmmu,qemu-system-%, \ > - $(SYSTEM_TARGETS)) > - > -USER_TARGETS=$(filter %-user,$(TARGET_DIRS)) > -USER_PROGS=$(patsubst %-bsd-user,qemu-%, \ > - $(patsubst %-darwin-user,qemu-%, \ > - $(patsubst %-linux-user,qemu-%, \ > - $(USER_TARGETS)))) > - > -# generate a binary distribution > -tarbin: > - cd /&& tar zcvf ~/qemu-$(VERSION)-$(ARCH).tar.gz \ > - $(patsubst %,$(bindir)/%, $(SYSTEM_PROGS)) \ > - $(patsubst %,$(bindir)/%, $(USER_PROGS)) \ > - $(bindir)/qemu-img \ > - $(bindir)/qemu-nbd \ > - $(datadir)/bios.bin \ > - $(datadir)/vgabios.bin \ > - $(datadir)/vgabios-cirrus.bin \ > - $(datadir)/ppc_rom.bin \ > - $(datadir)/openbios-sparc32 \ > - $(datadir)/openbios-sparc64 \ > - $(datadir)/openbios-ppc \ > - $(datadir)/pxe-e1000.rom \ > - $(datadir)/pxe-eepro100.rom \ > - $(datadir)/pxe-ne2k_pci.rom \ > - $(datadir)/pxe-pcnet.rom \ > - $(datadir)/pxe-rtl8139.rom \ > - $(datadir)/pxe-virtio.rom \ > - $(docdir)/qemu-doc.html \ > - $(docdir)/qemu-tech.html \ > - $(mandir)/man1/qemu.1 \ > - $(mandir)/man1/qemu-img.1 \ > - $(mandir)/man8/qemu-nbd.8 > - > # Include automatically generated dependency files > -include $(wildcard *.d audio/*.d slirp/*.d block/*.d net/*.d ui/*.d qapi/*.d qga/*.d)