From: "Hervé Poussineau" <hpoussin@reactos.org>
To: Avi Kivity <avi@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 01/13] mips_jazz: convert to memory API
Date: Sun, 25 Sep 2011 14:37:51 +0200 [thread overview]
Message-ID: <4E7F209F.10602@reactos.org> (raw)
In-Reply-To: <4E7F15BD.9010900@redhat.com>
Avi Kivity a écrit :
> On 09/25/2011 12:18 PM, Avi Kivity wrote:
>> On 09/24/2011 11:29 AM, Hervé Poussineau wrote:
>>>
>>> This part breaks Magnum emulation, where firmware writes to
>>> 0x60000000, and then checks if value has been modified.
>>> This is not working as expected (value is modified) because
>>> memory_region_set_readonly() is unimplemented...
>>
>> Whoops! Will provide a fix asap.
>>
>
> Please test the attached patch (works for me with 440FX PAM)
>
Yes, this patch also fixes Magnum emulation.
Thanks.
Hervé
next prev parent reply other threads:[~2011-09-25 12:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-24 8:29 [Qemu-devel] [PATCH 01/13] mips_jazz: convert to memory API Hervé Poussineau
2011-09-25 9:18 ` Avi Kivity
2011-09-25 11:51 ` Avi Kivity
2011-09-25 12:37 ` Hervé Poussineau [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-09-21 8:19 [Qemu-devel] [PULL 00/13] Memory API conversion, batch 8 Avi Kivity
2011-09-21 8:19 ` [Qemu-devel] [PATCH 01/13] mips_jazz: convert to memory API Avi Kivity
2011-09-18 14:15 [Qemu-devel] [PATCH 00/13] Memory API conversion, batch 8 Avi Kivity
2011-09-18 14:15 ` [Qemu-devel] [PATCH 01/13] mips_jazz: convert to memory API Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E7F209F.10602@reactos.org \
--to=hpoussin@reactos.org \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).