qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi
Date: Sun, 25 Sep 2011 17:07:01 +0300	[thread overview]
Message-ID: <4E7F3585.40108@redhat.com> (raw)
In-Reply-To: <4E7C51E4.2000503@cn.fujitsu.com>

On 09/23/2011 12:31 PM, Lai Jiangshan wrote:
> >  Moreover: wrong indention.
> >
> >  You know that this won't work for qemu-kvm with in-kernel irqchip? You
> >  may want to provide a patch for that tree, emulating the unavailable
> >  LINT1 injection via testing the APIC configration and then raising an
> >  NMI as before if it is accepted.
> >
>
> It works in my box but the NMI is not injected through the in-kernel irqchip,
> I will implement it as you suggested.

Somewhat hacky; isn't it better to test LINT1 in the kernel (and 
redefine the KVM_NMI ioctl as "toggle LINT1")?


-- 
error compiling committee.c: too many arguments to function

  parent reply	other threads:[~2011-09-25 14:07 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20110913093835.GB4265@localhost.localdomain>
     [not found] ` <20110914093441.e2bb305c.kamezawa.hiroyu@jp.fujitsu.com>
     [not found]   ` <4E705BC3.5000508@cn.fujitsu.com>
     [not found]     ` <20110915164704.9cacd407.kamezawa.hiroyu@jp.fujitsu.com>
     [not found]       ` <4E71B28F.7030201@cn.fujitsu.com>
     [not found]         ` <4E72F3BA.2000603@jp.fujitsu.com>
     [not found]           ` <4E73200A.7040908@jp.fujitsu.com>
     [not found]             ` <4E76C6AA.9080403@cn.fujitsu.com>
2011-09-22  9:50               ` [Qemu-devel] [PATCH] qemu: Fix inject-nmi Lai Jiangshan
2011-09-22 14:51                 ` Jan Kiszka
2011-09-23  9:31                   ` Lai Jiangshan
2011-09-23  9:35                     ` Jan Kiszka
2011-09-25 14:07                     ` Avi Kivity [this message]
2011-09-25 17:22                       ` Jan Kiszka
2011-09-26  8:21                         ` Avi Kivity
2011-10-10  6:06                           ` Lai Jiangshan
2011-10-10  6:06                           ` [Qemu-devel] [PATCH] kernel/kvm: fix improper nmi emulation (was: Re: [PATCH] qemu: Fix inject-nmi) Lai Jiangshan
2011-10-10  6:40                             ` [Qemu-devel] [PATCH] kernel/kvm: fix improper nmi emulation Jan Kiszka
2011-10-10 10:26                             ` Avi Kivity
2011-10-11 17:00                               ` [Qemu-devel] [PATCH 1/1 V2] " Lai Jiangshan
2011-10-11 18:06                                 ` Jan Kiszka
2011-10-14  0:54                                   ` [Qemu-devel] [PATCH 1/1 V3] " Lai Jiangshan
2011-10-16  8:54                                     ` Avi Kivity
2011-10-16  9:05                                       ` Jan Kiszka
2011-10-16  9:28                                         ` Avi Kivity
2011-10-12  7:02                                 ` [Qemu-devel] [PATCH 1/1 V2] " Kenji Kaneshige
2011-10-12  7:01                               ` [Qemu-devel] [PATCH] " Kenji Kaneshige
2011-10-10  6:06                           ` [Qemu-devel] [PATCH] qemu-kvm: fix improper nmi emulation (was: Re: [PATCH] qemu: Fix inject-nmi) Lai Jiangshan
2011-10-10  6:49                             ` [Qemu-devel] [PATCH] qemu-kvm: fix improper nmi emulation Jan Kiszka
2011-10-10  9:47                               ` Andreas Färber
2011-10-11 17:03                               ` [Qemu-devel] [PATCH 1/2 V2] qemu-kvm: Synchronize kernel headers Lai Jiangshan
2011-10-11 17:03                               ` [Qemu-devel] [PATCH 2/2 V2] qemu-kvm: fix improper nmi emulation Lai Jiangshan
2011-10-11 18:17                                 ` Jan Kiszka
2011-10-14  0:53                                   ` Lai Jiangshan
2011-10-14  5:53                                     ` Jan Kiszka
2011-10-14  6:36                                       ` [Qemu-devel] [PATCH 1/1 V4] " Lai Jiangshan
2011-10-14  6:49                                         ` Jan Kiszka
2011-10-14  7:43                                           ` Lai Jiangshan
2011-10-14  8:31                                             ` Jan Kiszka
2011-10-14  9:03                                           ` [Qemu-devel] [PATCH 1/1 V5] kernel/kvm: introduce KVM_SET_LINT1 and " Lai Jiangshan
2011-10-14  9:07                                             ` Jan Kiszka
2011-10-14  9:27                                               ` Lai Jiangshan
2011-10-14  9:32                                                 ` Jan Kiszka
2011-10-16  9:39                                             ` Avi Kivity
2011-10-17  9:17                                               ` Lai Jiangshan
2011-10-17  9:54                                                 ` Avi Kivity
2011-10-17 10:21                                                   ` Jan Kiszka
2011-10-17  9:40                                               ` Lai Jiangshan
2011-10-17  9:49                                                 ` Avi Kivity
2011-10-17 16:00                                                   ` [Qemu-devel] [PATCH 1/1 V6] qemu-kvm: " Lai Jiangshan
2011-10-18 19:41                                                     ` Jan Kiszka
2011-10-19  6:33                                                       ` Lai Jiangshan
2011-10-19 10:57                                                         ` Jan Kiszka
2011-10-19 15:21                                                           ` [Qemu-devel] [PATCH 1/1 V6] qemu: " Lai Jiangshan
2011-10-19  9:29                                                       ` [Qemu-devel] [PATCH 1/1 V6] qemu-kvm: " Avi Kivity
2011-10-19 15:32                                                         ` Lai Jiangshan
2011-12-07 10:29                                                     ` Avi Kivity
2011-12-08  9:42                                                       ` Jan Kiszka
2011-12-08 10:20                                                         ` Jan Kiszka
2011-10-14  9:03                                           ` [Qemu-devel] [PATCH 1/2 V5] qemu-kvm: Synchronize kernel headers Lai Jiangshan
2011-10-14  9:03                                           ` [Qemu-devel] [PATCH 2/2 V5] qemu-kvm: fix improper nmi emulation Lai Jiangshan
2011-10-14  9:22                                             ` Jan Kiszka
2011-10-14  9:51                                           ` [Qemu-devel] [PATCH 1/1 V5 tuning] kernel/kvm: introduce KVM_SET_LINT1 and " Lai Jiangshan
2011-10-14 11:59                                             ` Sasha Levin
2011-10-14 12:07                                               ` Jan Kiszka
2011-10-16 15:01                                                 ` Lai Jiangshan
2011-10-14  9:51                                           ` [Qemu-devel] [PATCH 1/2 V5 tuning] qemu-kvm: Synchronize kernel headers Lai Jiangshan
2011-10-14  0:54                                   ` [Qemu-devel] [PATCH 1/1 V3] qemu-kvm: fix improper nmi emulation Lai Jiangshan
2011-10-10  6:06                           ` [Qemu-devel] [PATCH 1/2] seabios: Add Local APIC NMI Structure to ACPI MADT (was: Re: [PATCH] qemu: Fix inject-nmi) Lai Jiangshan
2011-10-28 12:08                             ` [Qemu-devel] [PATCH 1/2] seabios: Add Local APIC NMI Structure to ACPI MADT Kenji Kaneshige
2011-10-28 12:19                               ` Gleb Natapov
2011-10-28 12:48                               ` Jun Koi
2011-10-31  8:00                                 ` Kenji Kaneshige
2011-10-30 14:44                             ` Avi Kivity
2011-10-30 14:44                               ` Avi Kivity
2011-10-10  6:06                           ` [Qemu-devel] [PATCH 2/2] seabios: fix mptable nmi entry (was: Re: [PATCH] qemu: Fix inject-nmi) Lai Jiangshan
2011-10-30 17:52                             ` Kevin O'Connor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E7F3585.40108@redhat.com \
    --to=avi@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kaneshige.kenji@jp.fujitsu.com \
    --cc=kvm@vger.kernel.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).