From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:33312)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R7pMO-0002FV-Is
	for qemu-devel@nongnu.org; Sun, 25 Sep 2011 10:07:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R7pMN-0001em-Kl
	for qemu-devel@nongnu.org; Sun, 25 Sep 2011 10:07:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37067)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R7pMN-0001eg-DM
	for qemu-devel@nongnu.org; Sun, 25 Sep 2011 10:07:11 -0400
Message-ID: <4E7F3585.40108@redhat.com>
Date: Sun, 25 Sep 2011 17:07:01 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <20110913093835.GB4265@localhost.localdomain>	<20110914093441.e2bb305c.kamezawa.hiroyu@jp.fujitsu.com>	<4E705BC3.5000508@cn.fujitsu.com>	<20110915164704.9cacd407.kamezawa.hiroyu@jp.fujitsu.com>	<4E71B28F.7030201@cn.fujitsu.com>
	<4E72F3BA.2000603@jp.fujitsu.com>	<4E73200A.7040908@jp.fujitsu.com>
	<4E76C6AA.9080403@cn.fujitsu.com>	<4E7B04DC.1030407@cn.fujitsu.com>
	<4E7B4B8F.507@siemens.com> <4E7C51E4.2000503@cn.fujitsu.com>
In-Reply-To: <4E7C51E4.2000503@cn.fujitsu.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qemu: Fix inject-nmi
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>

On 09/23/2011 12:31 PM, Lai Jiangshan wrote:
> >  Moreover: wrong indention.
> >
> >  You know that this won't work for qemu-kvm with in-kernel irqchip? You
> >  may want to provide a patch for that tree, emulating the unavailable
> >  LINT1 injection via testing the APIC configration and then raising an
> >  NMI as before if it is accepted.
> >
>
> It works in my box but the NMI is not injected through the in-kernel irqchip,
> I will implement it as you suggested.

Somewhat hacky; isn't it better to test LINT1 in the kernel (and 
redefine the KVM_NMI ioctl as "toggle LINT1")?


-- 
error compiling committee.c: too many arguments to function