From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R8GZj-0006nR-IM for qemu-devel@nongnu.org; Mon, 26 Sep 2011 15:10:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R8GZi-0004W6-H2 for qemu-devel@nongnu.org; Mon, 26 Sep 2011 15:10:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1548) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R8GZi-0004Vp-6s for qemu-devel@nongnu.org; Mon, 26 Sep 2011 15:10:46 -0400 Message-ID: <4E80CDE2.6010306@redhat.com> Date: Mon, 26 Sep 2011 22:09:22 +0300 From: Avi Kivity MIME-Version: 1.0 References: <20110926163509.020984459@linux.vnet.ibm.com> <20110926163729.645611239@linux.vnet.ibm.com> <20110926190905.GD22278@redhat.com> In-Reply-To: <20110926190905.GD22278@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V9 2/5] Add TPM (frontend) hardware interface (TPM TIS) to Qemu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: serge@hallyn.com, andreas.niederl@iaik.tugraz.at, qemu-devel@nongnu.org, anbang.ruan@cs.ox.ac.uk, Stefan Berger On 09/26/2011 10:09 PM, Michael S. Tsirkin wrote: > > + cpu_register_physical_memory(TPM_TIS_ADDR_BASE, > > + 0x1000 * TPM_TIS_NUM_LOCALITIES, > > + iomemtype); > > I think memory_region_init_io are supposed to be used for new devices > from now on... Right, Avi? > Correct. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.