From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:37324)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1R8Kgx-0002Hx-MH
	for qemu-devel@nongnu.org; Mon, 26 Sep 2011 19:34:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1R8Kgw-0002sf-Ir
	for qemu-devel@nongnu.org; Mon, 26 Sep 2011 19:34:31 -0400
Received: from e33.co.us.ibm.com ([32.97.110.151]:40894)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanb@linux.vnet.ibm.com>) id 1R8Kgw-0002sY-Bs
	for qemu-devel@nongnu.org; Mon, 26 Sep 2011 19:34:30 -0400
Received: from /spool/local by us.ibm.com with XMail ESMTP
	for <qemu-devel@nongnu.org> from <stefanb@linux.vnet.ibm.com>;
	Mon, 26 Sep 2011 17:34:28 -0600
Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169])
	by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p8QNXlUA176508
	for <qemu-devel@nongnu.org>; Mon, 26 Sep 2011 17:33:47 -0600
Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1])
	by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id p8QNXkV2014601
	for <qemu-devel@nongnu.org>; Mon, 26 Sep 2011 17:33:47 -0600
Message-ID: <4E810BDA.8040502@linux.vnet.ibm.com>
Date: Mon, 26 Sep 2011 19:33:46 -0400
From: Stefan Berger <stefanb@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <20110926163509.020984459@linux.vnet.ibm.com>
	<20110926163728.368010654@linux.vnet.ibm.com>
	<20110926190347.GC22278@redhat.com>
In-Reply-To: <20110926190347.GC22278@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V9 1/5] Support for TPM command line options
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: anbang.ruan@cs.ox.ac.uk, andreas.niederl@iaik.tugraz.at, qemu-devel@nongnu.org, serge@hallyn.com

On 09/26/2011 03:03 PM, Michael S. Tsirkin wrote:
> On Mon, Sep 26, 2011 at 12:35:10PM -0400, Stefan Berger wrote:
>> +void tpm_display_backend_drivers(FILE *out)
>> +{
>> +    int i;
>> +
>> +    fprintf(out, "Supported TPM types (choose only one):\n");
>> +
>> +    for (i = 0; bes[i] != NULL; i++) {
>> +        fprintf(out, "%12s   %s",
>> +                bes[i]->id, bes[i]->desc());
>> +        fprintf(out, "\n");
>> +    }
>> +    fprintf(out, "\n");
>> +}
> This dumps to stderr and so for qmp users it won't be correctly ordered.
> I'd suggest simply using error_report. This means '?' goes to stderr,
> not stdout, but that is consistent with e.g. -device '?'.
>
Though with error_report you get something like this here:

qemu-system-x86_64: -tpmdev ?: Supported TPM types (choose only one):

I don't think that's what we want. Let me just change it to *always* 
print to stderr.

     Stefan