From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R8NHp-0002V2-HG for qemu-devel@nongnu.org; Mon, 26 Sep 2011 22:20:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R8NHo-0002A7-BY for qemu-devel@nongnu.org; Mon, 26 Sep 2011 22:20:45 -0400 Received: from e1.ny.us.ibm.com ([32.97.182.141]:43247) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R8NHo-00029n-7u for qemu-devel@nongnu.org; Mon, 26 Sep 2011 22:20:44 -0400 Received: from /spool/local by us.ibm.com with XMail ESMTP for from ; Mon, 26 Sep 2011 22:20:37 -0400 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p8R2KEJd213084 for ; Mon, 26 Sep 2011 22:20:14 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p8R2KE3b008935 for ; Mon, 26 Sep 2011 23:20:14 -0300 Message-ID: <4E8132DD.6030601@linux.vnet.ibm.com> Date: Mon, 26 Sep 2011 22:20:13 -0400 From: Stefan Berger MIME-Version: 1.0 References: <20110926163509.020984459@linux.vnet.ibm.com> <20110926163731.347726806@linux.vnet.ibm.com> <20110926192019.GE22278@redhat.com> <4E80DCA3.3000606@linux.vnet.ibm.com> <20110926202430.GA23402@redhat.com> In-Reply-To: <20110926202430.GA23402@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V9 5/5] Add a TPM Passthrough backend driver implementation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: serge@hallyn.com, qemu-devel@nongnu.org, anbang.ruan@cs.ox.ac.uk, andreas.niederl@iaik.tugraz.at On 09/26/2011 04:24 PM, Michael S. Tsirkin wrote: > On Mon, Sep 26, 2011 at 04:12:19PM -0400, Stefan Berger wrote: > >>>> + if (tpm_passthrough_test_tpmdev(tb->s.tpm_pt->tpm_fd)) { >>>> + fprintf(stderr, >>>> + "'%s' is not a TPM device.\n", >>>> + tb->s.tpm_pt->tpm_dev); >>>> + goto err_close_tpmdev; >>> Is this a must? Is it common to have more than one >>> tpm device available on a computer? Maybe there's >>> a good default in case only one tpm exists there ... >>> >> Well, passing /dev/tty48 in the place of /dev/tpm0 ends up in a >> disappointment. So I'd rather check what that device is and refuse >> to start if it is found not to be a TPM. > Sorry, I mean can path= be made optional in case there's a single > /dev/tmpXXX? Is it even common to have any tpms except > /dev/tpm0? No, typically there is only one TPM in the machine and it's accessible using /dev/tpm0. SR-IOV TPMs afaik don't exist. So, yes, I am adding '/dev/tpm0' as the default now. > > All good answers shall likely go into the documentation :) I'll write about it... Will likely post v10 tomorrow. Stefan