From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:44710)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R8TUJ-0006tj-2M
	for qemu-devel@nongnu.org; Tue, 27 Sep 2011 04:58:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R8TUF-00035l-6b
	for qemu-devel@nongnu.org; Tue, 27 Sep 2011 04:58:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55473)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R8TUE-00035e-RS
	for qemu-devel@nongnu.org; Tue, 27 Sep 2011 04:57:59 -0400
Message-ID: <4E819012.6090100@redhat.com>
Date: Tue, 27 Sep 2011 11:57:54 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <4E7A828A.3030404@codemonkey.ws>
	<CAAu8pHs7uMeusg1PoMkDrxew6WzOaSGJJJgtbDAwwwKwYeGx_Q@mail.gmail.com>
	<4E7F366F.9060501@redhat.com>
	<CAAu8pHtu4OaCniMC8+UC9oxKkyJoUgwBGsOadBWE7G9E8-+B7g@mail.gmail.com>
	<4E7F5B62.1090307@redhat.com>
	<CAAu8pHuoP2hpMOBh91DTG_SS5jtwLVgWiTJqnb14kS+EJmFhXw@mail.gmail.com>
	<4E804F20.2090007@redhat.com>
	<CAAu8pHvQApJRNQCsMUFc7NiuTKhdpzS+W-95-NWubbkusPOBtw@mail.gmail.com>
	<4E80B3EF.3070202@redhat.com>
	<CAAu8pHvs7c5+q9-D=kt-QVtY8ip-JoDRQyzZLoXb0nTO2N8=tQ@mail.gmail.com>
	<4E80B535.1030804@redhat.com>
	<CAAu8pHuW9EHizFyCZTpV01gdgPSdJEvBM839OsC7bXB8X-eE1g@mail.gmail.com>
	<4E818A5A.6000605@redhat.com>
In-Reply-To: <4E818A5A.6000605@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [FYI] Soft feature freeze for 1.0 is 10/15 (three
 weeks away)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 09/27/2011 11:33 AM, Avi Kivity wrote:
> On 09/26/2011 09:07 PM, Blue Swirl wrote:
>> >>  The default address is used for early serial printk in OpenBIOS, 
>> so it
>> >>  should still work.
>> >
>> >  Ok, so drop the extra mapping, but init the dynamic mapping to 
>> 0x80013000.
>>
>> That should work.
>
> It's already there (macio.c):
>
>     if (macio_state->escc_mem) {
>         memory_region_add_subregion(bar, 0x13000, macio_state->escc_mem);
>     }
>
> I'll drop the extra mapping.
>

Well, it's not that easy.  As the other mapping is part of an ordinary 
BAR, you need to setup the device (at least PCI_COMMAND and 
PCI_BASE_ADDRESS_0) so it responds to memory requests, and also enable 
the bridge.

We could hack it by having a low-priority mapping at 0x80013000, but it 
seems wrong.  Maybe the firmware should configure that BAR first?  What 
happens on real hardware?

-- 
error compiling committee.c: too many arguments to function