From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39020)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1R8Yge-00048E-8Y
	for qemu-devel@nongnu.org; Tue, 27 Sep 2011 10:31:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1R8Ygc-0002tJ-Dz
	for qemu-devel@nongnu.org; Tue, 27 Sep 2011 10:31:08 -0400
Received: from e5.ny.us.ibm.com ([32.97.182.145]:55173)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1R8Ygc-0002s0-AA
	for qemu-devel@nongnu.org; Tue, 27 Sep 2011 10:31:06 -0400
Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235])
	by e5.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p8RDxnRN007098
	for <qemu-devel@nongnu.org>; Tue, 27 Sep 2011 09:59:49 -0400
Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p8REUlmJ224828
	for <qemu-devel@nongnu.org>; Tue, 27 Sep 2011 10:30:47 -0400
Received: from d01av02.pok.ibm.com (loopback [127.0.0.1])
	by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	p8REUdsB004719
	for <qemu-devel@nongnu.org>; Tue, 27 Sep 2011 11:30:40 -0300
Message-ID: <4E81DE0D.6020105@us.ibm.com>
Date: Tue, 27 Sep 2011 09:30:37 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
References: <20110927112530.GA10828@redhat.com>
	<CAFEAcA-AJAq_FquJ5mUiHKL0t++YrEhTzD5gazG0V9j-PgO6pA@mail.gmail.com>
In-Reply-To: <CAFEAcA-AJAq_FquJ5mUiHKL0t++YrEhTzD5gazG0V9j-PgO6pA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH qemu] e1000: CTRL.RST emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, Dean Nelson <dnelson@redhat.com>, Jesse Brandeburg <jesse.brandeburg@intel.com>, qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>, Alex Williamson <alex.williamson@redhat.com>, Jeff Kirsher <jeffrey.t.kirsher@intel.com>, Kevin Wolf <mail@kevin-wolf.de>, Andy Gospodarek <andy@greyhouse.net>

On 09/27/2011 06:50 AM, Peter Maydell wrote:
> On 27 September 2011 12:25, Michael S. Tsirkin<mst@redhat.com>  wrote:
>> e1000 spec says CTRL.RST write should have the same effect
>> as bus reset, except that is preserves PCI Config.
>> Reset device registers and interrupts.
>>
>> Fix suggested by Andy Gospodarek<andy@greyhouse.net>
>
> Doesn't this have the same effect as this patch:
> http://patchwork.ozlabs.org/patch/108673/
>
> except that it's harder to read because it's moved a lot
> of code around in the file?
>
> (I think you have an extra qemu_set_irq() call in there,
> actually. But it was hard to find. Also your code has the
> bug that was in earlier revisions of Anthony's patch where
> after doing the reset you fall through and allow other bits
> in the ctrl register to be set.)

I didn't see your note which said not to rend the patch unless I produce a 
compiler that issues a warning.  Since Anthony P. was going to resubmit, I never 
looked into it further.

I honestly don't care at this point which patch gets merged.

Regards,

Anthony Liguori

>
> -- PMM