From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34396) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R8Z7s-0006mY-51 for qemu-devel@nongnu.org; Tue, 27 Sep 2011 10:59:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R8Z7q-0000xq-T6 for qemu-devel@nongnu.org; Tue, 27 Sep 2011 10:59:16 -0400 Received: from goliath.siemens.de ([192.35.17.28]:33491) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R8Z7q-0000xN-H3 for qemu-devel@nongnu.org; Tue, 27 Sep 2011 10:59:14 -0400 Message-ID: <4E81E4BB.1070209@siemens.com> Date: Tue, 27 Sep 2011 16:59:07 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4E78C42D.5030207@siemens.com> <20110921080600.GA9847@stefanha-thinkpad.localdomain> <4E80B50B.9000301@siemens.com> <4E80B55F.5020203@redhat.com> <4E80BFF3.8000907@us.ibm.com> <4E8190BE.3000801@redhat.com> <4E81D609.1060203@siemens.com> <4E81D88B.4020504@codemonkey.ws> <4E81DDDF.8050201@siemens.com> <4E81DEEA.10208@redhat.com> <4E81DF7C.4080403@siemens.com> <4E81E0C9.7030702@redhat.com> <4E81E18C.2000906@siemens.com> <4E81E227.6010509@redhat.com> <4E81E2C0.10909@siemens.com> <4E81E398.7010608@redhat.com> In-Reply-To: <4E81E398.7010608@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Use qemu_eventfd for POSIX AIO List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Kevin Wolf , Anthony Liguori , Stefan Hajnoczi , Marcelo Tosatti , qemu-devel On 2011-09-27 16:54, Avi Kivity wrote: > On 09/27/2011 05:50 PM, Jan Kiszka wrote: >> On 2011-09-27 16:48, Avi Kivity wrote: >>> On 09/27/2011 05:45 PM, Jan Kiszka wrote: >>>> I don't disagree that there is still room for improving the existing >>>> interface, generalizing to qemu_event. But that's not in the scope of >>>> this patch. >>>> >>> >>> Why not use event_notify.c? >> >> It doesn't solve the wrapping issue, it mandates eventfd support. >> > > We can add pipe fallbacks too (though if it was meant to use with vhost, > that's not what we want). Not a practical issue due to the dependency on much more recent vhost. So EventNotifier will have to be migrated over a generic solution as well. Again, that's food for additional patches. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux