From: Richard Henderson <rth@twiddle.net>
To: khansa@kics.edu.pk
Cc: peter.maydell@linaro.org, riku.voipio@iki.fi,
qemu-devel@nongnu.org, aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH 5/7] target-mips:Support for Cavium specific instructions
Date: Tue, 27 Sep 2011 08:14:31 -0700 [thread overview]
Message-ID: <4E81E857.1030607@twiddle.net> (raw)
In-Reply-To: <1317097027-23748-6-git-send-email-khansa@kics.edu.pk>
On 09/26/2011 09:17 PM, khansa@kics.edu.pk wrote:
> + switch (opc) {
> + case OPC_SEQI:
> + tcg_gen_setcondi_tl(TCG_COND_LT, cpu_gpr[rt], t0, 1);
> + opn = "seqi";
> + break;
> + case OPC_SNEI:
> + tcg_gen_setcondi_tl(TCG_COND_GT, cpu_gpr[rt], t0, 0);
> + opn = "snei";
> + break;
> + }
You didn't change anything wrt my comments from the last round.
r~
next prev parent reply other threads:[~2011-09-27 15:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-27 4:17 [Qemu-devel] [PATCH 0/7] MIPS64 user mode emulation in QEMU with Cavium specific instruction support khansa
2011-09-27 4:17 ` [Qemu-devel] [PATCH 1/7] linux-user:Support for MIPS64 user mode emulation in QEMU khansa
2011-09-27 4:17 ` [Qemu-devel] [PATCH 2/7] target-mips:enabling of 64 bit user mode and floating point operations khansa
2011-09-27 4:17 ` [Qemu-devel] [PATCH 3/7] linux-user:Signal handling for MIPS64 khansa
2011-09-27 4:17 ` [Qemu-devel] [PATCH 4/7] target-mips:Octeon cpu definition khansa
2011-09-27 4:17 ` [Qemu-devel] [PATCH 5/7] target-mips:Support for Cavium specific instructions khansa
2011-09-27 15:14 ` Richard Henderson [this message]
2011-09-28 8:29 ` Andreas Färber
2011-09-27 4:17 ` [Qemu-devel] [PATCH 6/7] Addition of Cavium instructions in disassembler khansa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E81E857.1030607@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=khansa@kics.edu.pk \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).