From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R8ZMl-0003ty-Qe for qemu-devel@nongnu.org; Tue, 27 Sep 2011 11:14:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R8ZMk-0003rJ-Sy for qemu-devel@nongnu.org; Tue, 27 Sep 2011 11:14:39 -0400 Received: from mail-ww0-f53.google.com ([74.125.82.53]:54462) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R8ZMk-0003rC-GX for qemu-devel@nongnu.org; Tue, 27 Sep 2011 11:14:38 -0400 Received: by wwg14 with SMTP id 14so6237846wwg.10 for ; Tue, 27 Sep 2011 08:14:37 -0700 (PDT) Sender: Richard Henderson Message-ID: <4E81E857.1030607@twiddle.net> Date: Tue, 27 Sep 2011 08:14:31 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1317097027-23748-1-git-send-email-khansa@kics.edu.pk> <1317097027-23748-6-git-send-email-khansa@kics.edu.pk> In-Reply-To: <1317097027-23748-6-git-send-email-khansa@kics.edu.pk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/7] target-mips:Support for Cavium specific instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: khansa@kics.edu.pk Cc: peter.maydell@linaro.org, riku.voipio@iki.fi, qemu-devel@nongnu.org, aurelien@aurel32.net On 09/26/2011 09:17 PM, khansa@kics.edu.pk wrote: > + switch (opc) { > + case OPC_SEQI: > + tcg_gen_setcondi_tl(TCG_COND_LT, cpu_gpr[rt], t0, 1); > + opn = "seqi"; > + break; > + case OPC_SNEI: > + tcg_gen_setcondi_tl(TCG_COND_GT, cpu_gpr[rt], t0, 0); > + opn = "snei"; > + break; > + } You didn't change anything wrt my comments from the last round. r~