Re: [Qemu-devel] [PATCH 1/5] qemu-char: make qemu_chr_event public

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 08/12/2011 03:57 PM, Anthony Liguori wrote:
> On 08/11/2011 07:25 AM, Hans de Goede wrote:
>> Make qemu_chr_event public so that it can be used by chardev code
>> which lives outside of qemu-char.c
>
> Normally, qemu_chr_generic_open() would be used to do this. Of course, there is no generic_close().
>
> Are you sure you don't need the BH indirection?

A bit of a late reply (I was / am still waiting to see how the new
improved chardev code ends up). Things seem to work fine without
the BH indirection for all the spice cases I've tested (agent and usbredir).

But it might indeed be a good idea to keep the BH indirection, so we
would need some way to have the BH indirection for close to, options:

1) DIY in spice-qemu-char.c
2) Add a generic_close function

I would prefer 2, what do you think?

Thanks & Regards,

Hans