From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43790) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R8acq-0004gL-7T for qemu-devel@nongnu.org; Tue, 27 Sep 2011 12:35:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R8acp-0003c8-B0 for qemu-devel@nongnu.org; Tue, 27 Sep 2011 12:35:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33445) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R8acp-0003bk-3L for qemu-devel@nongnu.org; Tue, 27 Sep 2011 12:35:19 -0400 Message-ID: <4E81FBEF.3020001@redhat.com> Date: Tue, 27 Sep 2011 18:38:07 +0200 From: Hans de Goede MIME-Version: 1.0 References: <1313065515-3815-1-git-send-email-hdegoede@redhat.com> <4E45314D.2020004@codemonkey.ws> In-Reply-To: <4E45314D.2020004@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/5] qemu-char: make qemu_chr_event public List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Gerd Hoffmann , qemu-devel@nongnu.org Hi, On 08/12/2011 03:57 PM, Anthony Liguori wrote: > On 08/11/2011 07:25 AM, Hans de Goede wrote: >> Make qemu_chr_event public so that it can be used by chardev code >> which lives outside of qemu-char.c > > Normally, qemu_chr_generic_open() would be used to do this. Of course, there is no generic_close(). > > Are you sure you don't need the BH indirection? A bit of a late reply (I was / am still waiting to see how the new improved chardev code ends up). Things seem to work fine without the BH indirection for all the spice cases I've tested (agent and usbredir). But it might indeed be a good idea to keep the BH indirection, so we would need some way to have the BH indirection for close to, options: 1) DIY in spice-qemu-char.c 2) Add a generic_close function I would prefer 2, what do you think? Thanks & Regards, Hans