From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53942) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R8lxU-0003Ca-EG for qemu-devel@nongnu.org; Wed, 28 Sep 2011 00:41:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R8lxS-0000KA-C9 for qemu-devel@nongnu.org; Wed, 28 Sep 2011 00:41:24 -0400 Received: from e28smtp02.in.ibm.com ([122.248.162.2]:43261) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R8lxR-0000Ju-3z for qemu-devel@nongnu.org; Wed, 28 Sep 2011 00:41:22 -0400 Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by e28smtp02.in.ibm.com (8.14.4/8.13.1) with ESMTP id p8S4fG7Q018200 for ; Wed, 28 Sep 2011 10:11:16 +0530 Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p8S4fGOl2404500 for ; Wed, 28 Sep 2011 10:11:16 +0530 Received: from d28av01.in.ibm.com (loopback [127.0.0.1]) by d28av01.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p8SF9aYC019008 for ; Wed, 28 Sep 2011 20:39:37 +0530 Message-ID: <4E82A550.5010400@linux.vnet.ibm.com> Date: Wed, 28 Sep 2011 12:40:48 +0800 From: Ray Wang MIME-Version: 1.0 References: <1317013358-19839-1-git-send-email-antonynpavlov@gmail.com> In-Reply-To: <1317013358-19839-1-git-send-email-antonynpavlov@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] gt64xxx.c: fix length modifier in DPRINTF format string List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Antony Pavlov Cc: qemu-devel@nongnu.org Tested-by: Ray Wang On 9/26/2011 1:02 PM, Antony Pavlov wrote: > The commit fc2bf44972349b078d8310466c3866615500e67f > changed the type of val argument of the function gt64120_writel() > from uint32_t to uint64_t, so we need to change the corresponding > length modifier from "%x" to "%" PRIx64. > > Signed-off-by: Antony Pavlov > --- > hw/gt64xxx.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/gt64xxx.c b/hw/gt64xxx.c > index c7df8c4..1defb6d 100644 > --- a/hw/gt64xxx.c > +++ b/hw/gt64xxx.c > @@ -543,19 +543,19 @@ static void gt64120_writel (void *opaque, target_phys_addr_t addr, > /* not really implemented */ > s->regs[saddr] = ~(~(s->regs[saddr]) | ~(val& 0xfffffffe)); > s->regs[saddr] |= !!(s->regs[saddr]& 0xfffffffe); > - DPRINTF("INTRCAUSE %x\n", val); > + DPRINTF("INTRCAUSE %" PRIx64 "\n", val); > break; > case GT_INTRMASK: > s->regs[saddr] = val& 0x3c3ffffe; > - DPRINTF("INTRMASK %x\n", val); > + DPRINTF("INTRMASK %" PRIx64 "\n", val); > break; > case GT_PCI0_ICMASK: > s->regs[saddr] = val& 0x03fffffe; > - DPRINTF("ICMASK %x\n", val); > + DPRINTF("ICMASK %" PRIx64 "\n", val); > break; > case GT_PCI0_SERR0MASK: > s->regs[saddr] = val& 0x0000003f; > - DPRINTF("SERR0MASK %x\n", val); > + DPRINTF("SERR0MASK %" PRIx64 "\n", val); > break; > > /* Reserved when only PCI_0 is configured. */ It's good. -- Best Regards, ------------------------------------------------- Ray Wang Linux Technology Center, KVM China IBM Corp., Beijing, China xianleiw@cn.ibm.com