From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48191)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1R8pWK-0007et-6j
	for qemu-devel@nongnu.org; Wed, 28 Sep 2011 04:29:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1R8pWJ-0006Mz-0x
	for qemu-devel@nongnu.org; Wed, 28 Sep 2011 04:29:36 -0400
Received: from fmmailgate01.web.de ([217.72.192.221]:36771)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1R8pWI-0006Mu-Ks
	for qemu-devel@nongnu.org; Wed, 28 Sep 2011 04:29:34 -0400
Message-ID: <4E82DADE.7050909@web.de>
Date: Wed, 28 Sep 2011 10:29:18 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
MIME-Version: 1.0
References: <1317097027-23748-1-git-send-email-khansa@kics.edu.pk>
	<1317097027-23748-6-git-send-email-khansa@kics.edu.pk>
In-Reply-To: <1317097027-23748-6-git-send-email-khansa@kics.edu.pk>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Sender: andreas.faerber@web.de
Subject: Re: [Qemu-devel] [PATCH 5/7] target-mips:Support for Cavium
 specific instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: khansa@kics.edu.pk
Cc: peter.maydell@linaro.org, riku.voipio@iki.fi, qemu-devel@nongnu.org, aurelien@aurel32.net, rth@twiddle.net

Am 27.09.2011 06:17, schrieb khansa@kics.edu.pk:
> From: Ehsan-ul-Haq, Abdul Qadeer, Abdul Waheed, Khansa Butt <khansa@kics.edu.pk>
>
>
> Signed-off-by: Khansa Butt <khansa@kics.edu.pk>

...nor all of mine from previous rounds. Including From vs.
Signed-off-by mixup (From is who sent the patch, not whom the code
originated from), Coding Style issues, misleading "Cavium specific"
comments, typos, ...

A space after the colon in the subject would be more visually pleasing, too.

Further, your patch series is completely missing versioning ([PATCH vX
n/m] and change log). Not seeing what you've actually changed for this
resubmission while still seeing unaddressed flaws we've pointed out
already becomes annoying after a while and will not help your patches
make it into the repository...

Regards,
Andreas