[Qemu-devel] [PATCH v3 0/6]: block: Add I/O status support

[Qemu-devel] [PATCH v3 0/6]: block: Add I/O status support

[Luiz Capitulino]

This series adds support to the block layer to keep track of devices'
I/O status. That information is also made available in QMP and HMP.

The goal here is to allow management applications that miss the
BLOCK_IO_ERROR event to able to query the VM to determine if any device has
caused the VM to stop and which device caused it.

Here's an HMP example:

  (qemu) info status 
  VM status: paused (io-error)
  (qemu) info block
  ide0-hd0: removable=0 io-status=ok file=disks/test2.img ro=0 drv=qcow2 encrypted=0
  ide0-hd1: removable=0 io-status=nospace file=/dev/vg_doriath/kvmtest ro=0 drv=qcow2 encrypted=0
  ide1-cd0: removable=1 locked=0 io-status=ok [not inserted]
  floppy0: removable=1 locked=0 [not inserted]
  sd0: removable=1 locked=0 [not inserted]

The session above shows that the VM is stopped due to an I/O error. By using
the info block command it's possible to determine that the 'ide0-hd1' device
caused the error, which turns out to be due to no space.

changelog
---------

v3

o Introduce bdrv_iostatus_disable()
o Also reset the I/O status on bdrv_attach_dev()
o Fix bad assert() in bdrv_iostatus_enable()
o Improve documentation

v2

o Rebase against latest master
o Renamed bdrv_iostatus_update() to bdrv_iostatus_set_err()
o Minor changelog clarifications

 block.c         |   57 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 block.h         |   10 +++++++++
 block_int.h     |    1 +
 hw/ide/core.c   |    2 +
 hw/scsi-disk.c  |    2 +
 hw/virtio-blk.c |    2 +
 monitor.c       |    6 +++++
 qmp-commands.hx |    6 +++++
 8 files changed, 86 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH 1/6] block: Keep track of devices' I/O status

[Luiz Capitulino]

This commit adds support to the BlockDriverState type to keep track
of devices' I/O status.

There are three possible status: BDRV_IOS_OK (no error), BDRV_IOS_ENOSPC
(no space error) and BDRV_IOS_FAILED (any other error). The distinction
between no space and other errors is important because a management
application may want to watch for no space in order to extend the
space assigned to the VM and put it to run again.

Qemu devices supporting the I/O status feature have to enable it
explicitly by calling bdrv_iostatus_enable() _and_ have to be
configured to stop the VM on errors (ie. werror=stop|enospc or
rerror=stop).

In case of multiple errors being triggered in sequence only the first
one is stored. The I/O status is always reset to BDRV_IOS_OK when the
'cont' command is issued.

Next commits will add support to some devices and extend the
query-block/info block commands to return the I/O status information.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 block.c     |   40 ++++++++++++++++++++++++++++++++++++++++
 block.h     |   10 ++++++++++
 block_int.h |    1 +
 monitor.c   |    6 ++++++
 4 files changed, 57 insertions(+), 0 deletions(-)

diff --git a/block.c b/block.c
index e3fe97f..96b047b 100644
--- a/block.c
+++ b/block.c
@@ -221,6 +221,7 @@ BlockDriverState *bdrv_new(const char *device_name)
     if (device_name[0] != '\0') {
         QTAILQ_INSERT_TAIL(&bdrv_states, bs, list);
     }
+    bdrv_iostatus_disable(bs);
     return bs;
 }
 
@@ -770,6 +771,7 @@ int bdrv_attach_dev(BlockDriverState *bs, void *dev)
         return -EBUSY;
     }
     bs->dev = dev;
+    bdrv_iostatus_reset(bs);
     return 0;
 }
 
@@ -3181,6 +3183,44 @@ int bdrv_in_use(BlockDriverState *bs)
     return bs->in_use;
 }
 
+void bdrv_iostatus_enable(BlockDriverState *bs)
+{
+    bs->iostatus = BDRV_IOS_OK;
+}
+
+/* The I/O status is only enabled if the drive explicitly
+ * enables it _and_ the VM is configured to stop on errors */
+bool bdrv_iostatus_is_enabled(const BlockDriverState *bs)
+{
+    return (bs->iostatus != BDRV_IOS_INVAL &&
+           (bs->on_write_error == BLOCK_ERR_STOP_ENOSPC ||
+            bs->on_write_error == BLOCK_ERR_STOP_ANY    ||
+            bs->on_read_error == BLOCK_ERR_STOP_ANY));
+}
+
+void bdrv_iostatus_disable(BlockDriverState *bs)
+{
+    bs->iostatus = BDRV_IOS_INVAL;
+}
+
+void bdrv_iostatus_reset(BlockDriverState *bs)
+{
+    if (bdrv_iostatus_is_enabled(bs)) {
+        bs->iostatus = BDRV_IOS_OK;
+    }
+}
+
+/* XXX: Today this is set by device models because it makes the implementation
+   quite simple. However, the block layer knows about the error, so it's
+   possible to implement this without device models being involved */
+void bdrv_iostatus_set_err(BlockDriverState *bs, int error)
+{
+    if (bdrv_iostatus_is_enabled(bs) && bs->iostatus == BDRV_IOS_OK) {
+        assert(error >= 0);
+        bs->iostatus = error == ENOSPC ? BDRV_IOS_ENOSPC : BDRV_IOS_FAILED;
+    }
+}
+
 void
 bdrv_acct_start(BlockDriverState *bs, BlockAcctCookie *cookie, int64_t bytes,
         enum BlockAcctType type)
diff --git a/block.h b/block.h
index 16bfa0a..e77988e 100644
--- a/block.h
+++ b/block.h
@@ -77,6 +77,16 @@ typedef enum {
     BDRV_ACTION_REPORT, BDRV_ACTION_IGNORE, BDRV_ACTION_STOP
 } BlockMonEventAction;
 
+typedef enum {
+    BDRV_IOS_INVAL, BDRV_IOS_OK, BDRV_IOS_FAILED, BDRV_IOS_ENOSPC,
+    BDRV_IOS_MAX
+} BlockIOStatus;
+
+void bdrv_iostatus_enable(BlockDriverState *bs);
+void bdrv_iostatus_reset(BlockDriverState *bs);
+void bdrv_iostatus_disable(BlockDriverState *bs);
+bool bdrv_iostatus_is_enabled(const BlockDriverState *bs);
+void bdrv_iostatus_set_err(BlockDriverState *bs, int error);
 void bdrv_mon_event(const BlockDriverState *bdrv,
                     BlockMonEventAction action, int is_read);
 void bdrv_info_print(Monitor *mon, const QObject *data);
diff --git a/block_int.h b/block_int.h
index 8c3b863..f2f4f2d 100644
--- a/block_int.h
+++ b/block_int.h
@@ -199,6 +199,7 @@ struct BlockDriverState {
        drivers. They are not used by the block driver */
     int cyls, heads, secs, translation;
     BlockErrorAction on_read_error, on_write_error;
+    BlockIOStatus iostatus;
     char device_name[32];
     unsigned long *dirty_bitmap;
     int64_t dirty_count;
diff --git a/monitor.c b/monitor.c
index 8ec2c5e..88d8228 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1304,6 +1304,11 @@ struct bdrv_iterate_context {
     int err;
 };
 
+static void iostatus_bdrv_it(void *opaque, BlockDriverState *bs)
+{
+    bdrv_iostatus_reset(bs);
+}
+
 /**
  * do_cont(): Resume emulation.
  */
@@ -1320,6 +1325,7 @@ static int do_cont(Monitor *mon, const QDict *qdict, QObject **ret_data)
         return -1;
     }
 
+    bdrv_iterate(iostatus_bdrv_it, NULL);
     bdrv_iterate(encrypted_bdrv_it, &context);
     /* only resume the vm if all keys are set and valid */
     if (!context.err) {
-- 
1.7.7.rc0.72.g4b5ea

[Qemu-devel] [PATCH 2/6] virtio: Support I/O status

[Luiz Capitulino]

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 hw/virtio-blk.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c
index daa8e42..bd63a85 100644
--- a/hw/virtio-blk.c
+++ b/hw/virtio-blk.c
@@ -78,6 +78,7 @@ static int virtio_blk_handle_rw_error(VirtIOBlockReq *req, int error,
         s->rq = req;
         bdrv_mon_event(s->bs, BDRV_ACTION_STOP, is_read);
         vm_stop(RSTATE_IO_ERROR);
+        bdrv_iostatus_set_err(s->bs, error);
     } else {
         virtio_blk_req_complete(req, VIRTIO_BLK_S_IOERR);
         bdrv_acct_done(s->bs, &req->acct);
@@ -603,6 +604,7 @@ VirtIODevice *virtio_blk_init(DeviceState *dev, BlockConf *conf,
     bdrv_set_dev_ops(s->bs, &virtio_block_ops, s);
     bdrv_set_buffer_alignment(s->bs, conf->logical_block_size);
 
+    bdrv_iostatus_enable(s->bs);
     add_boot_device_path(conf->bootindex, dev, "/disk@0,0");
 
     return &s->vdev;
-- 
1.7.7.rc0.72.g4b5ea

[Qemu-devel] [PATCH 3/6] ide: Support I/O status

[Luiz Capitulino]

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 hw/ide/core.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/hw/ide/core.c b/hw/ide/core.c
index 4e76fc7..9ec1310 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -528,6 +528,7 @@ static int ide_handle_rw_error(IDEState *s, int error, int op)
         s->bus->error_status = op;
         bdrv_mon_event(s->bs, BDRV_ACTION_STOP, is_read);
         vm_stop(RSTATE_IO_ERROR);
+        bdrv_iostatus_set_err(s->bs, error);
     } else {
         if (op & BM_STATUS_DMA_RETRY) {
             dma_buf_commit(s, 0);
@@ -1872,6 +1873,7 @@ int ide_init_drive(IDEState *s, BlockDriverState *bs, IDEDriveKind kind,
     }
 
     ide_reset(s);
+    bdrv_iostatus_enable(bs);
     return 0;
 }
 
-- 
1.7.7.rc0.72.g4b5ea

[Qemu-devel] [PATCH 4/6] scsi: Support I/O status

[Luiz Capitulino]

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 hw/scsi-disk.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index e843f71..a980a53 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -228,6 +228,7 @@ static int scsi_handle_rw_error(SCSIDiskReq *r, int error, int type)
 
         bdrv_mon_event(s->bs, BDRV_ACTION_STOP, is_read);
         vm_stop(RSTATE_IO_ERROR);
+        bdrv_iostatus_set_err(s->bs, error);
     } else {
         switch (error) {
         case ENOMEM:
@@ -1260,6 +1261,7 @@ static int scsi_initfn(SCSIDevice *dev, uint8_t scsi_type)
 
     s->qdev.type = scsi_type;
     qemu_add_vm_change_state_handler(scsi_dma_restart_cb, s);
+    bdrv_iostatus_enable(s->bs);
     add_boot_device_path(s->qdev.conf.bootindex, &dev->qdev, ",0");
     return 0;
 }
-- 
1.7.7.rc0.72.g4b5ea

[Qemu-devel] [PATCH 5/6] QMP: query-status: Add 'io-status' key

[Luiz Capitulino]

Contains the I/O status for the given device. The key is only present
if the device supports it and the VM is configured to stop on errors.

Please, check the documentation being added in this commit for more
information.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 block.c         |   12 ++++++++++++
 qmp-commands.hx |    6 ++++++
 2 files changed, 18 insertions(+), 0 deletions(-)

diff --git a/block.c b/block.c
index 96b047b..7053c80 100644
--- a/block.c
+++ b/block.c
@@ -1891,6 +1891,12 @@ void bdrv_info_print(Monitor *mon, const QObject *data)
     qlist_iter(qobject_to_qlist(data), bdrv_print_dict, mon);
 }
 
+static const char *const io_status_name[BDRV_IOS_MAX] = {
+    [BDRV_IOS_OK] = "ok",
+    [BDRV_IOS_FAILED] = "failed",
+    [BDRV_IOS_ENOSPC] = "nospace",
+};
+
 void bdrv_info(Monitor *mon, QObject **ret_data)
 {
     QList *bs_list;
@@ -1913,6 +1919,12 @@ void bdrv_info(Monitor *mon, QObject **ret_data)
             qdict_put(bs_dict, "tray-open",
                       qbool_from_int(bdrv_dev_is_tray_open(bs)));
         }
+
+        if (bdrv_iostatus_is_enabled(bs)) {
+            qdict_put(bs_dict, "io-status",
+                      qstring_from_str(io_status_name[bs->iostatus]));
+        }
+
         if (bs->drv) {
             QObject *obj;
 
diff --git a/qmp-commands.hx b/qmp-commands.hx
index d83bce5..34cc353 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -1145,6 +1145,10 @@ Each json-object contain the following:
                                 "tftp", "vdi", "vmdk", "vpc", "vvfat"
          - "backing_file": backing file name (json-string, optional)
          - "encrypted": true if encrypted, false otherwise (json-bool)
+- "io-status": I/O operation status, only present if the device supports it
+               and the VM is configured to stop on errors. It's always reset
+               to "ok" when the "cont" command is issued (json_string, optional)
+             - Possible values: "ok", "failed", "nospace"
 
 Example:
 
@@ -1152,6 +1156,7 @@ Example:
 <- {
       "return":[
          {
+            "io-status": "ok",
             "device":"ide0-hd0",
             "locked":false,
             "removable":false,
@@ -1164,6 +1169,7 @@ Example:
             "type":"unknown"
          },
          {
+            "io-status": "ok",
             "device":"ide1-cd0",
             "locked":false,
             "removable":true,
-- 
1.7.7.rc0.72.g4b5ea

[Qemu-devel] [PATCH 6/6] HMP: Print 'io-status' information

[Luiz Capitulino]

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 block.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/block.c b/block.c
index 7053c80..061b4cc 100644
--- a/block.c
+++ b/block.c
@@ -1866,6 +1866,11 @@ static void bdrv_print_dict(QObject *obj, void *opaque)
         monitor_printf(mon, " tray-open=%d",
                        qdict_get_bool(bs_dict, "tray-open"));
     }
+
+    if (qdict_haskey(bs_dict, "io-status")) {
+        monitor_printf(mon, " io-status=%s", qdict_get_str(bs_dict, "io-status"));
+    }
+
     if (qdict_haskey(bs_dict, "inserted")) {
         QDict *qdict = qobject_to_qdict(qdict_get(bs_dict, "inserted"));
 
-- 
1.7.7.rc0.72.g4b5ea

Re: [Qemu-devel] [PATCH v3 0/6]: block: Add I/O status support

[Markus Armbruster]

Luiz Capitulino <lcapitulino@redhat.com> writes:

> This series adds support to the block layer to keep track of devices'
> I/O status. That information is also made available in QMP and HMP.
>
> The goal here is to allow management applications that miss the
> BLOCK_IO_ERROR event to able to query the VM to determine if any device has
> caused the VM to stop and which device caused it.
>
> Here's an HMP example:
>
>   (qemu) info status 
>   VM status: paused (io-error)
>   (qemu) info block
>   ide0-hd0: removable=0 io-status=ok file=disks/test2.img ro=0 drv=qcow2 encrypted=0
>   ide0-hd1: removable=0 io-status=nospace file=/dev/vg_doriath/kvmtest ro=0 drv=qcow2 encrypted=0
>   ide1-cd0: removable=1 locked=0 io-status=ok [not inserted]
>   floppy0: removable=1 locked=0 [not inserted]
>   sd0: removable=1 locked=0 [not inserted]
>
> The session above shows that the VM is stopped due to an I/O error. By using
> the info block command it's possible to determine that the 'ide0-hd1' device
> caused the error, which turns out to be due to no space.

Reviewed-by: Markus Armbruster <armbru@redhat.com>

Re: [Qemu-devel] [PATCH v3 0/6]: block: Add I/O status support

[hkran]

On 09/27/2011 04:43 AM, Luiz Capitulino wrote:
> This series adds support to the block layer to keep track of devices'
> I/O status. That information is also made available in QMP and HMP.
>
> The goal here is to allow management applications that miss the
> BLOCK_IO_ERROR event to able to query the VM to determine if any device has
> caused the VM to stop and which device caused it.
>
> Here's an HMP example:
>
>    (qemu) info status
>    VM status: paused (io-error)
>    (qemu) info block
>    ide0-hd0: removable=0 io-status=ok file=disks/test2.img ro=0 drv=qcow2 encrypted=0
>    ide0-hd1: removable=0 io-status=nospace file=/dev/vg_doriath/kvmtest ro=0 drv=qcow2 encrypted=0
>    ide1-cd0: removable=1 locked=0 io-status=ok [not inserted]
>    floppy0: removable=1 locked=0 [not inserted]
>    sd0: removable=1 locked=0 [not inserted]
>
> The session above shows that the VM is stopped due to an I/O error. By using
> the info block command it's possible to determine that the 'ide0-hd1' device
> caused the error, which turns out to be due to no space.
>
> changelog
> ---------
>
> v3
>
> o Introduce bdrv_iostatus_disable()
> o Also reset the I/O status on bdrv_attach_dev()
> o Fix bad assert() in bdrv_iostatus_enable()
> o Improve documentation
>
> v2
>
> o Rebase against latest master
> o Renamed bdrv_iostatus_update() to bdrv_iostatus_set_err()
> o Minor changelog clarifications
>
>   block.c         |   57 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   block.h         |   10 +++++++++
>   block_int.h     |    1 +
>   hw/ide/core.c   |    2 +
>   hw/scsi-disk.c  |    2 +
>   hw/virtio-blk.c |    2 +
>   monitor.c       |    6 +++++
>   qmp-commands.hx |    6 +++++
>   8 files changed, 86 insertions(+), 0 deletions(-)
>
Hi,

How to reproduce a scenario in which the VM is stopped due to the I/O error?
I tried several times by copying data from one place to another place in 
guest OS and finally the system prompted me that there is no space is 
available, however it did not
cause any I/O error and not stop the VM either.

Re: [Qemu-devel] [PATCH v3 0/6]: block: Add I/O status support

[Luiz Capitulino]

On Wed, 28 Sep 2011 17:45:27 +0800
hkran <hkran@vnet.linux.ibm.com> wrote:

> On 09/27/2011 04:43 AM, Luiz Capitulino wrote:
> > This series adds support to the block layer to keep track of devices'
> > I/O status. That information is also made available in QMP and HMP.
> >
> > The goal here is to allow management applications that miss the
> > BLOCK_IO_ERROR event to able to query the VM to determine if any device has
> > caused the VM to stop and which device caused it.
> >
> > Here's an HMP example:
> >
> >    (qemu) info status
> >    VM status: paused (io-error)
> >    (qemu) info block
> >    ide0-hd0: removable=0 io-status=ok file=disks/test2.img ro=0 drv=qcow2 encrypted=0
> >    ide0-hd1: removable=0 io-status=nospace file=/dev/vg_doriath/kvmtest ro=0 drv=qcow2 encrypted=0
> >    ide1-cd0: removable=1 locked=0 io-status=ok [not inserted]
> >    floppy0: removable=1 locked=0 [not inserted]
> >    sd0: removable=1 locked=0 [not inserted]
> >
> > The session above shows that the VM is stopped due to an I/O error. By using
> > the info block command it's possible to determine that the 'ide0-hd1' device
> > caused the error, which turns out to be due to no space.
> >
> > changelog
> > ---------
> >
> > v3
> >
> > o Introduce bdrv_iostatus_disable()
> > o Also reset the I/O status on bdrv_attach_dev()
> > o Fix bad assert() in bdrv_iostatus_enable()
> > o Improve documentation
> >
> > v2
> >
> > o Rebase against latest master
> > o Renamed bdrv_iostatus_update() to bdrv_iostatus_set_err()
> > o Minor changelog clarifications
> >
> >   block.c         |   57 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >   block.h         |   10 +++++++++
> >   block_int.h     |    1 +
> >   hw/ide/core.c   |    2 +
> >   hw/scsi-disk.c  |    2 +
> >   hw/virtio-blk.c |    2 +
> >   monitor.c       |    6 +++++
> >   qmp-commands.hx |    6 +++++
> >   8 files changed, 86 insertions(+), 0 deletions(-)
> >
> Hi,
> 
> How to reproduce a scenario in which the VM is stopped due to the I/O error?
> I tried several times by copying data from one place to another place in 
> guest OS and finally the system prompted me that there is no space is 
> available, however it did not
> cause any I/O error and not stop the VM either.

I use the test-case described here:

 http://lists.gnu.org/archive/html/qemu-devel/2011-08/msg03800.html

Re: [Qemu-devel] [PATCH v3 0/6]: block: Add I/O status support

[Mark Wu]

On 09/27/2011 04:43 AM, Luiz Capitulino wrote:
> This series adds support to the block layer to keep track of devices'
> I/O status. That information is also made available in QMP and HMP.
>
> The goal here is to allow management applications that miss the
> BLOCK_IO_ERROR event to able to query the VM to determine if any device has
> caused the VM to stop and which device caused it.
>
> Here's an HMP example:
>
>    (qemu) info status
>    VM status: paused (io-error)
>    (qemu) info block
>    ide0-hd0: removable=0 io-status=ok file=disks/test2.img ro=0 drv=qcow2 encrypted=0
>    ide0-hd1: removable=0 io-status=nospace file=/dev/vg_doriath/kvmtest ro=0 drv=qcow2 encrypted=0
>    ide1-cd0: removable=1 locked=0 io-status=ok [not inserted]
>    floppy0: removable=1 locked=0 [not inserted]
>    sd0: removable=1 locked=0 [not inserted]
>
> The session above shows that the VM is stopped due to an I/O error. By using
> the info block command it's possible to determine that the 'ide0-hd1' device
> caused the error, which turns out to be due to no space.
>
>
I test it with the options enospc and stop on virtio and scsi models. It 
works fine.
Tested-by: Mark Wu <wudxw@vnet.linux.ibm.com>

Re: [Qemu-devel] [PATCH v3 0/6]: block: Add I/O status support

[Kevin Wolf]

Am 26.09.2011 22:43, schrieb Luiz Capitulino:
> This series adds support to the block layer to keep track of devices'
> I/O status. That information is also made available in QMP and HMP.
> 
> The goal here is to allow management applications that miss the
> BLOCK_IO_ERROR event to able to query the VM to determine if any device has
> caused the VM to stop and which device caused it.
> 
> Here's an HMP example:
> 
>   (qemu) info status 
>   VM status: paused (io-error)
>   (qemu) info block
>   ide0-hd0: removable=0 io-status=ok file=disks/test2.img ro=0 drv=qcow2 encrypted=0
>   ide0-hd1: removable=0 io-status=nospace file=/dev/vg_doriath/kvmtest ro=0 drv=qcow2 encrypted=0
>   ide1-cd0: removable=1 locked=0 io-status=ok [not inserted]
>   floppy0: removable=1 locked=0 [not inserted]
>   sd0: removable=1 locked=0 [not inserted]
> 
> The session above shows that the VM is stopped due to an I/O error. By using
> the info block command it's possible to determine that the 'ide0-hd1' device
> caused the error, which turns out to be due to no space.

Thanks, applied all to the block branch.

Kevin

Re: [Qemu-devel] [PATCH v3 0/6]: block: Add I/O status support

[Luiz Capitulino]

On Mon, 10 Oct 2011 19:30:32 +0200
Kevin Wolf <kwolf@redhat.com> wrote:

> Am 26.09.2011 22:43, schrieb Luiz Capitulino:
> > This series adds support to the block layer to keep track of devices'
> > I/O status. That information is also made available in QMP and HMP.
> > 
> > The goal here is to allow management applications that miss the
> > BLOCK_IO_ERROR event to able to query the VM to determine if any device has
> > caused the VM to stop and which device caused it.
> > 
> > Here's an HMP example:
> > 
> >   (qemu) info status 
> >   VM status: paused (io-error)
> >   (qemu) info block
> >   ide0-hd0: removable=0 io-status=ok file=disks/test2.img ro=0 drv=qcow2 encrypted=0
> >   ide0-hd1: removable=0 io-status=nospace file=/dev/vg_doriath/kvmtest ro=0 drv=qcow2 encrypted=0
> >   ide1-cd0: removable=1 locked=0 io-status=ok [not inserted]
> >   floppy0: removable=1 locked=0 [not inserted]
> >   sd0: removable=1 locked=0 [not inserted]
> > 
> > The session above shows that the VM is stopped due to an I/O error. By using
> > the info block command it's possible to determine that the 'ide0-hd1' device
> > caused the error, which turns out to be due to no space.
> 
> Thanks, applied all to the block branch.

This series will conflict with my "first round of qapi conversions" series.

It seems to me that the conflicts are rather simple, just doing
s/RSTATE_/RUN_STATE should fix them, but I can resend the series if you think
that's better.

> 
> Kevin
> 

Re: [Qemu-devel] [PATCH v3 0/6]: block: Add I/O status support

[Kevin Wolf]

Am 10.10.2011 22:25, schrieb Luiz Capitulino:
> On Mon, 10 Oct 2011 19:30:32 +0200
> Kevin Wolf <kwolf@redhat.com> wrote:
> 
>> Am 26.09.2011 22:43, schrieb Luiz Capitulino:
>>> This series adds support to the block layer to keep track of devices'
>>> I/O status. That information is also made available in QMP and HMP.
>>>
>>> The goal here is to allow management applications that miss the
>>> BLOCK_IO_ERROR event to able to query the VM to determine if any device has
>>> caused the VM to stop and which device caused it.
>>>
>>> Here's an HMP example:
>>>
>>>   (qemu) info status 
>>>   VM status: paused (io-error)
>>>   (qemu) info block
>>>   ide0-hd0: removable=0 io-status=ok file=disks/test2.img ro=0 drv=qcow2 encrypted=0
>>>   ide0-hd1: removable=0 io-status=nospace file=/dev/vg_doriath/kvmtest ro=0 drv=qcow2 encrypted=0
>>>   ide1-cd0: removable=1 locked=0 io-status=ok [not inserted]
>>>   floppy0: removable=1 locked=0 [not inserted]
>>>   sd0: removable=1 locked=0 [not inserted]
>>>
>>> The session above shows that the VM is stopped due to an I/O error. By using
>>> the info block command it's possible to determine that the 'ide0-hd1' device
>>> caused the error, which turns out to be due to no space.
>>
>> Thanks, applied all to the block branch.
> 
> This series will conflict with my "first round of qapi conversions" series.
> 
> It seems to me that the conflicts are rather simple, just doing
> s/RSTATE_/RUN_STATE should fix them, but I can resend the series if you think
> that's better.

Thanks for the heads-up. It seems to be a trivial conflict indeed and I
resolved it myself.

Kevin