From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:50196)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1R8v5f-0005QF-Km
	for qemu-devel@nongnu.org; Wed, 28 Sep 2011 10:26:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1R8v5e-0001IS-A7
	for qemu-devel@nongnu.org; Wed, 28 Sep 2011 10:26:27 -0400
Received: from mail-wy0-f173.google.com ([74.125.82.173]:36825)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1R8v5d-0001I5-VD
	for qemu-devel@nongnu.org; Wed, 28 Sep 2011 10:26:26 -0400
Received: by wyh22 with SMTP id 22so50943wyh.4
	for <qemu-devel@nongnu.org>; Wed, 28 Sep 2011 07:26:24 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4E832E88.6080909@twiddle.net>
Date: Wed, 28 Sep 2011 07:26:16 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <4E8312D7.4080403@siemens.com>
In-Reply-To: <4E8312D7.4080403@siemens.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] tcg-i386: Introduce specific deposit
	helpers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel <qemu-devel@nongnu.org>, Aurelien Jarno <aurelien@aurel32.net>

On 09/28/2011 05:28 AM, Jan Kiszka wrote:
> +#if TCG_TARGET_REG_BITS == 64
> +    { INDEX_op_deposit8l_i32, { "r", "0", "r" } },
> +#else
> +    { INDEX_op_deposit8l_i32, { "abcd", "0", "abcd" } },
> +#endif

At minimum, abcd is spelled "q".

I don't particularly care for the 3 different opcodes.  Perhaps
we'd be better off with an inline predicate for when the deposit
opcode is "valid"?


r~