From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48405)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1R8x0f-0005pC-Hv
	for qemu-devel@nongnu.org; Wed, 28 Sep 2011 12:29:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1R8x0e-0000Zy-IV
	for qemu-devel@nongnu.org; Wed, 28 Sep 2011 12:29:25 -0400
Received: from mail-ww0-f53.google.com ([74.125.82.53]:44815)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1R8x0e-0000Zq-Bc
	for qemu-devel@nongnu.org; Wed, 28 Sep 2011 12:29:24 -0400
Received: by wwg14 with SMTP id 14so7853829wwg.10
	for <qemu-devel@nongnu.org>; Wed, 28 Sep 2011 09:29:23 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4E834B5E.2070103@twiddle.net>
Date: Wed, 28 Sep 2011 09:29:18 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <cover.1317207666.git.jan.kiszka@siemens.com>
	<3f13e9a857d1ee5c101b0dc88deea908d6a29234.1317207666.git.jan.kiszka@siemens.com>
	<4E8349FE.7010006@twiddle.net>
In-Reply-To: <4E8349FE.7010006@twiddle.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 17/22] i8259: Eliminate PicState2
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>

On 09/28/2011 09:23 AM, Richard Henderson wrote:
> On 09/28/2011 04:01 AM, Jan Kiszka wrote:
>> +    s = g_malloc0(sizeof(PicState));
> 
> Probably better to convert to g_new0 at this time.

Nevermind.  I now see this code goes away again in a few patches.


r~