From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39770)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1R8xAb-00085M-9i
	for qemu-devel@nongnu.org; Wed, 28 Sep 2011 12:39:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1R8xAa-0002S0-3q
	for qemu-devel@nongnu.org; Wed, 28 Sep 2011 12:39:41 -0400
Received: from mail-wy0-f173.google.com ([74.125.82.173]:38889)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1R8xAZ-0002Ru-TN
	for qemu-devel@nongnu.org; Wed, 28 Sep 2011 12:39:40 -0400
Received: by wyh22 with SMTP id 22so219816wyh.4
	for <qemu-devel@nongnu.org>; Wed, 28 Sep 2011 09:39:39 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4E834DC6.9020408@twiddle.net>
Date: Wed, 28 Sep 2011 09:39:34 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <cover.1317207666.git.jan.kiszka@siemens.com>
In-Reply-To: <cover.1317207666.git.jan.kiszka@siemens.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 00/22] Rework i8259 and PC interrupt models
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>

On 09/28/2011 04:00 AM, Jan Kiszka wrote:
> Highlights of this series:
>  - generic i8259, now part of hwlib
>  - qdev conversion of i8259
>  - fix for i8259 poll mode (and removal of PREP hack)
> 
> The refactoring will also be important to instantiate i8259-kvm devices
> for in-kernel irqchip acceleration one day.
> 
> Note: depends on "mips_fulong2e: Reorder ISA bus and i8259 creation"
> 
> CC: Alexander Graf <agraf@suse.de>

All of the patches look reasonable.  I'll try and give it a try with
my alpha port sometime soon.

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~