From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53997) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R92HT-0001ie-PV for qemu-devel@nongnu.org; Wed, 28 Sep 2011 18:07:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R92HS-0006Nq-Tq for qemu-devel@nongnu.org; Wed, 28 Sep 2011 18:07:07 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:47538) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R92HS-0006Nd-Ai for qemu-devel@nongnu.org; Wed, 28 Sep 2011 18:07:06 -0400 Message-ID: <4E839A88.4060003@web.de> Date: Thu, 29 Sep 2011 00:07:04 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4E8312D7.4080403@siemens.com> <4E832E88.6080909@twiddle.net> <4E83304F.4010008@siemens.com> <4E833AEA.8080508@twiddle.net> In-Reply-To: <4E833AEA.8080508@twiddle.net> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig7152B77B9E1A0D580B8780BB" Sender: jan.kiszka@web.de Subject: Re: [Qemu-devel] [PATCH] tcg-i386: Introduce specific deposit helpers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: Blue Swirl , qemu-devel , Aurelien Jarno This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig7152B77B9E1A0D580B8780BB Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 2011-09-28 17:19, Richard Henderson wrote: > On 09/28/2011 07:33 AM, Jan Kiszka wrote: >>> I don't particularly care for the 3 different opcodes. Perhaps >>> we'd be better off with an inline predicate for when the deposit >>> opcode is "valid"? >> >> We still need to dispatch at tcg generation time which variant is vali= d. Or what do you have in mind? >=20 > Yes, but we'd know at tcg generation time that it *does* fit one of > the few patterns you point out. >=20 > The predicate would be used in e.g. tcg_gen_deposit_i32 to select > either INDEX_op_deposit_i32 or the and/shift/and/or fallback. I think I'm slowly starting to understand: #define TCG_TARGET_HAS_deposit_i32(ofs, len) \ (((ofs) =3D=3D 0 && (len) =3D=3D 8 && TCG_TARGET_HAS_deposit8l_i32) |= | \ ...) defined by the i386 tcg target, right? Jan --------------enig7152B77B9E1A0D580B8780BB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk6DmogACgkQitSsb3rl5xSwFwCgnLUb8Cc1u+q6bPRTxwiPtEuG hQAAoJpzZMp8pBRPEakPMz0C4Ab+hYC8 =MiFA -----END PGP SIGNATURE----- --------------enig7152B77B9E1A0D580B8780BB--