From: Richard Henderson <rth@twiddle.net>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Blue Swirl <blauwirbel@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] tcg-i386: Introduce specific deposit helpers
Date: Wed, 28 Sep 2011 15:47:19 -0700 [thread overview]
Message-ID: <4E83A3F7.3000508@twiddle.net> (raw)
In-Reply-To: <4E839A88.4060003@web.de>
On 09/28/2011 03:07 PM, Jan Kiszka wrote:
> On 2011-09-28 17:19, Richard Henderson wrote:
>> On 09/28/2011 07:33 AM, Jan Kiszka wrote:
>>>> I don't particularly care for the 3 different opcodes. Perhaps
>>>> we'd be better off with an inline predicate for when the deposit
>>>> opcode is "valid"?
>>>
>>> We still need to dispatch at tcg generation time which variant is valid. Or what do you have in mind?
>>
>> Yes, but we'd know at tcg generation time that it *does* fit one of
>> the few patterns you point out.
>>
>> The predicate would be used in e.g. tcg_gen_deposit_i32 to select
>> either INDEX_op_deposit_i32 or the and/shift/and/or fallback.
>
> I think I'm slowly starting to understand:
>
> #define TCG_TARGET_HAS_deposit_i32(ofs, len) \
> (((ofs) == 0 && (len) == 8 && TCG_TARGET_HAS_deposit8l_i32) || \
> ...)
>
> defined by the i386 tcg target, right?
Something like that. Except without the TCG_TARGET_HAS_deposit8l_i32.
r~
next prev parent reply other threads:[~2011-09-28 22:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 12:28 [Qemu-devel] [PATCH] tcg-i386: Introduce specific deposit helpers Jan Kiszka
2011-09-28 14:26 ` Richard Henderson
2011-09-28 14:33 ` Jan Kiszka
2011-09-28 15:19 ` Richard Henderson
2011-09-28 22:07 ` Jan Kiszka
2011-09-28 22:47 ` Richard Henderson [this message]
2011-09-29 11:31 ` [Qemu-devel] [PATCH v2] tcg-i386: Introduce limited deposit support Jan Kiszka
2011-09-29 14:58 ` Richard Henderson
2011-09-29 15:19 ` Jan Kiszka
2011-09-29 15:23 ` [Qemu-devel] [PATCH v3] " Jan Kiszka
2011-09-29 16:11 ` Richard Henderson
2011-09-29 16:52 ` [Qemu-devel] [PATCH v4] " Jan Kiszka
2011-09-29 19:50 ` Richard Henderson
2011-10-01 12:06 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E83A3F7.3000508@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).