From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:52529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R9Du7-0007QC-Hs for qemu-devel@nongnu.org; Thu, 29 Sep 2011 06:31:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R9Du6-0002Hw-HM for qemu-devel@nongnu.org; Thu, 29 Sep 2011 06:31:47 -0400 Received: from mail-wy0-f173.google.com ([74.125.82.173]:53330) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R9Du6-0002Hp-96 for qemu-devel@nongnu.org; Thu, 29 Sep 2011 06:31:46 -0400 Received: by wyh22 with SMTP id 22so134725wyh.4 for ; Thu, 29 Sep 2011 03:31:44 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4E84490B.1050108@redhat.com> Date: Thu, 29 Sep 2011 12:31:39 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1317269995-8275-1-git-send-email-david@gibson.dropbear.id.au> In-Reply-To: <1317269995-8275-1-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] pseries: Update SLOF firmware image List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: thuth@de.ibm.com, agraf@suse.de, qemu-devel@nongnu.org On 09/29/2011 06:19 AM, David Gibson wrote: > This patch updates the SLOF submodule and recompiled image. The new > SLOF versions contains two changes of note: > > * The previous SLOF has a bug in SCSI condition handling that was > exposed by recent updates to qemu's SCSI emulation. This update > fixes the bug. > > * The previous SLOF has a bug in its addressing of SCSI devices, > which can be exposed under certain conditions. The new SLOF also > fixes this. Did you really fix this? The SLOF.bin file here seems to be the same as in patch 50/58 from Alex's pull request, and the submodule likewise does not contain this fix. Neither does your SLOF upstream repo, in fact. :) Also, you're not updating pc-bios/README. Paolo