From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53445)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1R9IPU-00071K-Ko
	for qemu-devel@nongnu.org; Thu, 29 Sep 2011 11:20:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1R9IPO-0000Hn-Vw
	for qemu-devel@nongnu.org; Thu, 29 Sep 2011 11:20:28 -0400
Received: from thoth.sbs.de ([192.35.17.2]:27992)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1R9IPO-0000Hd-IE
	for qemu-devel@nongnu.org; Thu, 29 Sep 2011 11:20:22 -0400
Message-ID: <4E848CB3.2000608@siemens.com>
Date: Thu, 29 Sep 2011 17:20:19 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1317304660-18072-1-git-send-email-levinsasha928@gmail.com>
	<4E847C56.4020701@siemens.com> <004801cc7eb5$c00c6580$40253080$@de>
In-Reply-To: <004801cc7eb5$c00c6580$40253080$@de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] tap: Add optional parameters to up/down
	script
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thomas Jung <Swoop3r@gmx.de>, 'Sasha Levin' <levinsasha928@gmail.com>
Cc: 'Anthony Liguori' <aliguori@us.ibm.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 2011-09-29 16:40, Thomas Jung wrote:
> On 2011-09-29 16:11 jan kiszka wrote
>> What kind of parameters would you want to pass? Something that tells VMs
>> apart (which can be solved without these extensions) or more?
>>
>> Jan
> 
> In our Case:
> 
> We want to simulate an larger environment with multiple switches realized in
> openvswitch.
> Openvswitch requires a up- and downscript for each switch. So the idea was,
> have a single and variable up- and downscript and feed it with parameters
> (like switch to use, vlan id and so on) through the scriptparams. 

Sounds reasonable. A short note on the "why" in the description would
have been nice.

The patch has some style issues that should be addressed first
(checkpatch will tell).

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux