qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	Fabien Chouteau <chouteau@adacore.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] Delayed IP packets
Date: Thu, 29 Sep 2011 19:53:47 +0200	[thread overview]
Message-ID: <4E84B0AB.1060303@siemens.com> (raw)
In-Reply-To: <20110929175037.GA21901@amit-x200.redhat.com>

On 2011-09-29 19:50, Amit Shah wrote:
> On (Thu) 29 Sep 2011 [19:41:33], Jan Kiszka wrote:
>> On 2011-09-29 18:06, Amit Shah wrote:
>>> On (Wed) 03 Aug 2011 [13:24:22], Jan Kiszka wrote:
>>>> From: Fabien Chouteau <chouteau@adacore.com>
>>>>
>>>> In the current implementation, if Slirp tries to send an IP packet to a client
>>>> with an unknown hardware address, the packet is simply dropped and an ARP
>>>> request is sent (if_encap in slirp/slirp.c).
>>>>
>>>> With this patch, Slirp will send the ARP request, re-queue the packet and try
>>>> to send it later. The packet is dropped after one second if the ARP reply is
>>>> not received.
>>>
>>> This patch causes a segfault when guests wake up from hibernate.
>>>
>>> Recipe:
>>> 1. Start guest with -net user -net nic,model=virtio
>>> 2. (guest) ping 10.0.2.2
>>> 3. (guest) echo "disk" > /sys/power/state
>>> 4. Re-start guest with same command line
>>> 5. Ping has stopped receiving replies.
>>> 6. Kill that ping process and start a new one.  qemu segfaults.
>>
>> Can't reproduce, I'm not getting stable hibernation here even without
>> any network configured.
> 
> With virtio devices and the patches applied?  Can you tell me what
> you're seeing?

No, I didn't patch my guest. I was using standard IDE with an emulated
NIC (or without) against a 3.1-rc3 (or so) guest.

> 
>> Could you check if the recent pull request [1] changes the picture for you?
> 
> Thanks, that series fixes the problem.

Perfect! Right in time. :)

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

  reply	other threads:[~2011-09-29 17:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-03 11:24 [Qemu-devel] [PATCH 0/3] [PULL] slirp: ARP table improvements Jan Kiszka
2011-08-03 11:24 ` [Qemu-devel] [PATCH 1/3] slirp: Take maintainer token Jan Kiszka
2011-08-03 11:24 ` [Qemu-devel] [PATCH 2/3] Simple ARP table Jan Kiszka
2011-08-03 11:24 ` [Qemu-devel] [PATCH 3/3] Delayed IP packets Jan Kiszka
2011-09-29 16:06   ` Amit Shah
2011-09-29 17:41     ` Jan Kiszka
2011-09-29 17:50       ` Amit Shah
2011-09-29 17:53         ` Jan Kiszka [this message]
2011-09-29 18:05           ` Amit Shah
2011-09-29 18:19             ` Jan Kiszka
2011-09-29 18:27               ` Amit Shah
2011-11-22 12:03     ` Alexander Graf
2011-08-04 22:43 ` [Qemu-devel] [PATCH 0/3] [PULL] slirp: ARP table improvements Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E84B0AB.1060303@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=aliguori@us.ibm.com \
    --cc=amit.shah@redhat.com \
    --cc=chouteau@adacore.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).