From: Jan Kiszka <jan.kiszka@siemens.com>
To: Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>
Cc: Blue Swirl <blauwirbel@gmail.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PATCH 2/2] Drop obsolete nographic timer
Date: Fri, 30 Sep 2011 12:31:18 +0200 [thread overview]
Message-ID: <4E859A76.2000808@siemens.com> (raw)
We flush coalesced MMIO in the device models now, and VNC - for which
this was once introduced - is also fine without it as it has its own
refresh timer.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
vl.c | 13 -------------
1 files changed, 0 insertions(+), 13 deletions(-)
diff --git a/vl.c b/vl.c
index 54d4dd9..db5ed7c 100644
--- a/vl.c
+++ b/vl.c
@@ -247,8 +247,6 @@ int nb_numa_nodes;
uint64_t node_mem[MAX_NODES];
uint64_t node_cpumask[MAX_NODES];
-static QEMUTimer *nographic_timer;
-
uint8_t qemu_uuid[16];
static QEMUBootSetHandler *boot_set_handler;
@@ -1221,13 +1219,6 @@ static void gui_update(void *opaque)
qemu_mod_timer(ds->gui_timer, interval + qemu_get_clock_ms(rt_clock));
}
-static void nographic_update(void *opaque)
-{
- uint64_t interval = GUI_REFRESH_INTERVAL;
-
- qemu_mod_timer(nographic_timer, interval + qemu_get_clock_ms(rt_clock));
-}
-
struct vm_change_state_entry {
VMChangeStateHandler *cb;
void *opaque;
@@ -3522,10 +3513,6 @@ int main(int argc, char **argv, char **envp)
}
dcl = dcl->next;
}
- if (ds->gui_timer == NULL) {
- nographic_timer = qemu_new_timer_ms(rt_clock, nographic_update, NULL);
- qemu_mod_timer(nographic_timer, qemu_get_clock_ms(rt_clock));
- }
text_consoles_set_display(ds);
if (gdbstub_dev && gdbserver_start(gdbstub_dev) < 0) {
--
1.7.3.4
next reply other threads:[~2011-09-30 10:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 10:31 Jan Kiszka [this message]
2011-10-14 0:05 ` [Qemu-devel] [PATCH 2/2] Drop obsolete nographic timer David Gibson
2011-11-01 20:10 ` Anthony Liguori
2011-11-01 20:15 ` Blue Swirl
2011-11-01 20:20 ` Anthony Liguori
2012-03-10 6:19 ` Marek Vasut
2012-03-10 10:44 ` Jan Kiszka
2012-03-11 23:39 ` Marek Vasut
2012-03-15 18:12 ` Marek Vasut
2012-03-15 21:53 ` Jan Kiszka
2012-03-16 0:52 ` Marek Vasut
2012-03-16 8:17 ` Jan Kiszka
2012-03-16 8:55 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E859A76.2000808@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).