From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36340) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R9aln-0003Tz-6O for qemu-devel@nongnu.org; Fri, 30 Sep 2011 06:56:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R9alm-0003bo-26 for qemu-devel@nongnu.org; Fri, 30 Sep 2011 06:56:43 -0400 Received: from e28smtp07.in.ibm.com ([122.248.162.7]:54270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R9all-0003bk-C5 for qemu-devel@nongnu.org; Fri, 30 Sep 2011 06:56:41 -0400 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by e28smtp07.in.ibm.com (8.14.4/8.13.1) with ESMTP id p8UAucOR029965 for ; Fri, 30 Sep 2011 16:26:38 +0530 Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p8UAubYX4436126 for ; Fri, 30 Sep 2011 16:26:37 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p8UGQHEY030761 for ; Sat, 1 Oct 2011 02:26:17 +1000 Message-ID: <4E85A065.4070802@linux.vnet.ibm.com> Date: Fri, 30 Sep 2011 16:26:37 +0530 From: Harsh Bora MIME-Version: 1.0 References: <1317299989-30571-1-git-send-email-harsh@linux.vnet.ibm.com> <20110929171651.GA1624@stefanha-thinkpad.localdomain> In-Reply-To: <20110929171651.GA1624@stefanha-thinkpad.localdomain> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 0/2] Replace 9p debug infrastructure with Qemu Tracing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, aneesh.kumar@linux.vnet.ibm.com On 09/29/2011 10:46 PM, Stefan Hajnoczi wrote: > On Thu, Sep 29, 2011 at 06:09:47PM +0530, Harsh Prateek Bora wrote: >> This patchset introduces Qemu Tracing to 9p pdu handlers and removes the >> existing debug infrastructure which becomes less meaningful after the >> introduction of coroutines. Parallel operations creates a messy output and >> filtering becomes difficult. With Qemu tracing in place, we can selectively >> enable/disable trace-events and the trace log can be further filtered using >> analysis scripts. >> >> Harsh Prateek Bora (2): >> Introduce tracing for 9p pdu handlers >> Remove virtio-9p-debug.* infra since we are using Qemu Tracing now. >> >> Makefile.objs | 2 +- >> hw/9pfs/virtio-9p-debug.c | 646 --------------------------------------------- >> hw/9pfs/virtio-9p-debug.h | 6 - >> hw/9pfs/virtio-9p.c | 70 +++++- >> trace-events | 47 ++++ >> 5 files changed, 110 insertions(+), 661 deletions(-) >> delete mode 100644 hw/9pfs/virtio-9p-debug.c >> delete mode 100644 hw/9pfs/virtio-9p-debug.h > > Reviewed-by: Stefan Hajnoczi > > It would also be neat to wire up 9p pdu's to the pcap code in net/dump.c > so it's possible to capture 9p sessions and look at them with wireshark. Thanks Stefan for a quick response. I have sent a v2 for this patch incorporating aneesh's review comments with an additional patch to provide an analysis python script. I shall look into pcap code sometime soon. Harsh > > Stefan >